From: Andreas Schwab <schwab@suse.de>
To: Jiri Benc <jbenc@suse.cz>
Cc: Bernd Petrovitsch <bernd@firmix.at>,
rusty@rustcorp.com.au, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] modpost: fix buffer overflow
Date: Wed, 15 Mar 2006 16:35:43 +0100 [thread overview]
Message-ID: <je4q1zpvow.fsf@sykes.suse.de> (raw)
In-Reply-To: <20060315160858.311e5c0e@griffin.suse.cz> (Jiri Benc's message of "Wed, 15 Mar 2006 16:08:58 +0100")
Jiri Benc <jbenc@suse.cz> writes:
> + while (buf->size - buf->pos < len + 1)
> + buf->size += 128;
What's wrong with
buf->size = buf->pos + len + 1;
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2006-03-15 15:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-15 14:44 Jiri Benc
2006-03-15 14:55 ` Bernd Petrovitsch
2006-03-15 14:57 ` Bernd Petrovitsch
2006-03-15 15:08 ` Jiri Benc
2006-03-15 15:35 ` Andreas Schwab [this message]
2006-03-15 22:51 ` Sam Ravnborg
2006-03-16 13:21 ` Jiri Benc
2006-03-16 15:46 ` Sam Ravnborg
2006-03-16 18:59 ` [PATCH] kbuild: fix buffer overflow in modpost Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=je4q1zpvow.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=bernd@firmix.at \
--cc=jbenc@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®