* [PATCH] Hamradio: Fix a NULL pointer dereference in net/hamradio/6pack.c
@ 2006-03-16 6:46 Eugene Teo
2006-03-16 7:10 ` Eugene Teo
0 siblings, 1 reply; 3+ messages in thread
From: Eugene Teo @ 2006-03-16 6:46 UTC (permalink / raw)
To: linux-kernel
Cc: Thomas Osterried DL9SAU, Ralf Baechle DL5RB, Hans Alblas PE1AYX
Pointer sp is dereferenced before NULL check.
Coverity bug #816
Signed-off-by: Eugene Teo <eugene.teo@eugeneteo.net>
--- linux-2.6/drivers/net/hamradio/6pack.c~ 2006-03-15 10:05:35.000000000 +0800
+++ linux-2.6/drivers/net/hamradio/6pack.c 2006-03-16 14:43:44.000000000 +0800
@@ -726,13 +726,16 @@ static void sixpack_close(struct tty_str
static int sixpack_ioctl(struct tty_struct *tty, struct file *file,
unsigned int cmd, unsigned long arg)
{
- struct sixpack *sp = sp_get(tty);
- struct net_device *dev = sp->dev;
+ struct sixpack *sp;
+ struct net_device *dev;
unsigned int tmp, err;
if (!sp)
return -ENXIO;
+ sp = sp_get(tty);
+ dev = sp->dev;
+
switch(cmd) {
case SIOCGIFNAME:
err = copy_to_user((void __user *) arg, dev->name,
--
1024D/A6D12F80 print D51D 2633 8DAC 04DB 7265 9BB8 5883 6DAA A6D1 2F80
main(i) { putchar(182623909 >> (i-1) * 5&31|!!(i<7)<<6) && main(++i); }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Hamradio: Fix a NULL pointer dereference in net/hamradio/6pack.c
2006-03-16 6:46 [PATCH] Hamradio: Fix a NULL pointer dereference in net/hamradio/6pack.c Eugene Teo
@ 2006-03-16 7:10 ` Eugene Teo
2006-03-16 8:11 ` David S. Miller
0 siblings, 1 reply; 3+ messages in thread
From: Eugene Teo @ 2006-03-16 7:10 UTC (permalink / raw)
To: linux-kernel
Cc: Thomas Osterried DL9SAU, Ralf Baechle DL5RB, Hans Alblas PE1AYX
<quote sender="Eugene Teo">
> Pointer sp is dereferenced before NULL check.
>
> Coverity bug #816
>
> Signed-off-by: Eugene Teo <eugene.teo@eugeneteo.net>
Ignore the previous patch please. Here's a resend.
--
Pointer sp is dereferenced before NULL check.
Coverity bug #816
Signed-off-by: Eugene Teo <eugene.teo@eugeneteo.net>
--- linux-2.6/drivers/net/hamradio/6pack.c~ 2006-03-15 10:05:35.000000000 +0800
+++ linux-2.6/drivers/net/hamradio/6pack.c 2006-03-16 15:08:43.000000000 +0800
@@ -727,12 +727,14 @@ static int sixpack_ioctl(struct tty_stru
unsigned int cmd, unsigned long arg)
{
struct sixpack *sp = sp_get(tty);
- struct net_device *dev = sp->dev;
+ struct net_device *dev;
unsigned int tmp, err;
if (!sp)
return -ENXIO;
+ dev = sp->dev;
+
switch(cmd) {
case SIOCGIFNAME:
err = copy_to_user((void __user *) arg, dev->name,
--
1024D/A6D12F80 print D51D 2633 8DAC 04DB 7265 9BB8 5883 6DAA A6D1 2F80
main(i) { putchar(182623909 >> (i-1) * 5&31|!!(i<7)<<6) && main(++i); }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Hamradio: Fix a NULL pointer dereference in net/hamradio/6pack.c
2006-03-16 7:10 ` Eugene Teo
@ 2006-03-16 8:11 ` David S. Miller
0 siblings, 0 replies; 3+ messages in thread
From: David S. Miller @ 2006-03-16 8:11 UTC (permalink / raw)
To: eugene.teo; +Cc: linux-kernel, thomas, ralf, hans
From: Eugene Teo <eugene.teo@eugeneteo.net>
Date: Thu, 16 Mar 2006 15:10:28 +0800
> Pointer sp is dereferenced before NULL check.
>
> Coverity bug #816
>
> Signed-off-by: Eugene Teo <eugene.teo@eugeneteo.net>
Also applied, thanks a lot.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-03-16 8:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-03-16 6:46 [PATCH] Hamradio: Fix a NULL pointer dereference in net/hamradio/6pack.c Eugene Teo
2006-03-16 7:10 ` Eugene Teo
2006-03-16 8:11 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®