From: Andrew Morton <akpm@osdl.org>
To: Hugh Dickins <hugh@veritas.com>
Cc: rlrevell@joe-job.com, mingo@elte.hu, nickpiggin@yahoo.com.au,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix free swap cache latency
Date: Thu, 16 Mar 2006 17:38:08 -0800 [thread overview]
Message-ID: <20060316173808.3be343b0.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0603161853300.24463@goblin.wat.veritas.com>
Hugh Dickins <hugh@veritas.com> wrote:
>
> (*zap_work)--;
> continue;
> }
> +
> + (*zap_work) -= PAGE_SIZE;
Sometimes we subtract 1 from zap_work, sometimes PAGE_SIZE. It's in units
of bytes, so PAGE_SIZE is correct. Although it would make sense to
redefine it to be in units of PAGE_SIZE. What's up with that?
Even better, define it in units of "approximate number of touched
cachelines". After all, it is a sort-of-time-based thing.
next prev parent reply other threads:[~2006-03-17 1:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-16 19:11 Hugh Dickins
2006-03-16 22:07 ` Ingo Molnar
2006-03-17 1:38 ` Andrew Morton [this message]
2006-03-17 2:52 ` Nick Piggin
2006-03-17 17:55 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060316173808.3be343b0.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nickpiggin@yahoo.com.au \
--cc=rlrevell@joe-job.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®