* [PATCH] Dont create a control file for BSP that cannot be removed
@ 2006-03-17 12:30 Ashok Raj
0 siblings, 0 replies; only message in thread
From: Ashok Raj @ 2006-03-17 12:30 UTC (permalink / raw)
To: akpm; +Cc: vatsa, ak, shaohua.li, linux-kernel
Hi Andrew
this patch just doesnt create an online file if the logical cpu cannot be
offlined.
We originally added to support ppc64 if the kernel has support but BIOS indicated
no offline support, we just didnt create online files for them.
We used the same method in ia64 as well, if we have a cpu taking platform interrupts
but cannot be removed if those interrupts cannot be re-targeted to another cpu.
--
Cheers,
Ashok Raj
- Open Source Technology Center
Don't create "online" control file for BSP (i386/x86_64) since its
not removable.
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
-----------------------------------------------------------
arch/i386/kernel/topology.c | 9 +++++++++
1 files changed, 9 insertions(+)
Index: linux-2.6.16-rc6-mm1/arch/i386/kernel/topology.c
===================================================================
--- linux-2.6.16-rc6-mm1.orig/arch/i386/kernel/topology.c
+++ linux-2.6.16-rc6-mm1/arch/i386/kernel/topology.c
@@ -41,6 +41,15 @@ int arch_register_cpu(int num){
parent = &node_devices[node].node;
#endif /* CONFIG_NUMA */
+ /*
+ * CPU0 cannot be offlined due to several
+ * restrictions and assumptions in kernel. This basically
+ * doesnt add a control file, one cannot attempt to offline
+ * BSP.
+ */
+ if (!num)
+ cpu_devices[num].cpu.no_control = 1;
+
return register_cpu(&cpu_devices[num].cpu, num, parent);
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-03-17 12:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-03-17 12:30 [PATCH] Dont create a control file for BSP that cannot be removed Ashok Raj
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome