From: Srivatsa Vaddagiri <vatsa@in.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org,
shaohua.li@intel.com, bryce@osdl.org, ashok.raj@intel.com
Subject: Re: [PATCH] Check for online cpus before bringing them up
Date: Fri, 17 Mar 2006 19:43:22 +0530 [thread overview]
Message-ID: <20060317141322.GB27325@in.ibm.com> (raw)
In-Reply-To: <20060317010412.3243364c.akpm@osdl.org>
On Fri, Mar 17, 2006 at 01:04:12AM -0800, Andrew Morton wrote:
> OK.. I guess we should fix those architectures while we're thinking about it.
Only x86 has this bug, so only x86 needs to be fixed. Neverthless
Ashok's patch [1] should address all architectures that may implement
smp_prepare_cpu() in future as well.
> How well tested is this? From my reading, this will cause
> enable_nonboot_cpus() to panic. Is that intended?
I have done some basic test of the patch using Bryce's scripts.
Regarding enable_nonboot_cpus(), from my reading of it, it should not
call smp_prepare_cpu on online cpus, so the check added should not cause
it to panic. Am I missing something?
Finally, I think the patch Ashok posted sometime back [1] is probably a more
neater solution to this bug (he probably needs to modify it slightly to
remove smp_prepare_cpu from enable_nonboot_cpus as well).
[1] http://lkml.org/lkml/2006/3/17/103
--
Regards,
vatsa
next prev parent reply other threads:[~2006-03-17 14:13 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-16 17:44 Srivatsa Vaddagiri
2006-03-17 1:08 ` Andrew Morton
2006-03-17 1:16 ` Shaohua Li
2006-03-17 8:46 ` Srivatsa Vaddagiri
2006-03-17 9:04 ` Andrew Morton
2006-03-17 14:13 ` Srivatsa Vaddagiri [this message]
2006-03-18 14:09 ` Ashok Raj
2006-03-21 1:08 ` Shaohua Li
2006-03-21 1:25 ` Ashok Raj
2006-03-21 1:36 ` Shaohua Li
2006-10-06 23:10 ` Status on CPU hotplug issues Bryce Harrington
2006-10-06 23:29 ` Andrew Morton
2006-10-07 0:00 ` Bryce Harrington
2006-10-07 10:35 ` Pavel Machek
2006-10-07 20:42 ` Bryce Harrington
2006-10-08 18:29 ` Heiko Carstens
2006-10-08 19:14 ` Pavel Machek
2006-10-11 1:08 ` [BUG] 2.6.19-rc1-mm1: fs/file.c138 on ia64 Bryce Harrington
2006-10-11 1:15 ` Andrew Morton
2006-10-11 5:38 ` Bryce Harrington
2006-10-07 10:24 ` Status on CPU hotplug issues Pavel Machek
2006-10-07 20:25 ` Bryce Harrington
2006-10-08 19:13 ` Pavel Machek
2006-10-09 7:42 ` Bryce Harrington
2006-10-07 21:57 ` Pavel Machek
2006-10-09 21:40 ` Randy Dunlap
2006-10-23 22:26 ` Bryce Harrington
2006-11-08 5:35 ` Randy Dunlap
2006-11-08 5:52 ` Bryce Harrington
2006-03-17 12:21 ` [PATCH] Check for online cpus before bringing them up Ashok Raj
2006-03-17 13:59 ` Srivatsa Vaddagiri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060317141322.GB27325@in.ibm.com \
--to=vatsa@in.ibm.com \
--cc=akpm@osdl.org \
--cc=ashok.raj@intel.com \
--cc=bryce@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®