saa7111.c patch

saa7111.c patch

[Martin Samuelsson]

[-- Attachment #1: Type: text/plain, Size: 663 bytes --]

Hello.

When grabbing composite video with Iomega Buz, the stock driver will prevent grabbing from the same input twice in a row, forcing the user to switch inputs before anything useful can be grabbed again. It is caused by some optimization code in the input selection parts, and triggered by the saa7111_command() executing cmd 0. The attached patch will remedy this by disabling cmd 0 altogether; a fix that has no found negative effects on the rest of the code. In fact, saa7110.c does the exact same thing.

It would be nice to have this included in the kernel driver.

I'd appreciate being kept in the recipient list in case of discussion.

Regards,
/Sam


[-- Attachment #2: linux-2.6.15.6-buz.diff --]
[-- Type: application/octet-stream, Size: 301 bytes --]

--- linux-2.6.15.6/drivers/media/video/saa7111.c	2006-03-05 20:07:54.000000000 +0100
+++ linux-2.6.15.6-buz/drivers/media/video/saa7111.c	2006-03-19 02:18:27.000000000 +0100
@@ -210,6 +210,7 @@
 	switch (cmd) {
 
 	case 0:
+	  break;
 	case DECODER_INIT:
 	{
 		struct video_decoder_init *init = arg;

Re: saa7111.c patch

[Ronald S. Bultje]

Hi,

On Sun, 19 Mar 2006, Martin Samuelsson wrote:
> When grabbing composite video with Iomega Buz, the stock driver will
> prevent grabbing from the same input twice in a row, forcing the user
> to switch inputs before anything useful can be grabbed again. It is
> caused by some optimization code in the input selection parts, and
> triggered by the saa7111_command() executing cmd 0. The attached patch
> will remedy this by disabling cmd 0 altogether; a fix that has no found
> negative effects on the rest of the code. In fact, saa7110.c does the
> exact same thing.

I second this patch, can you please add it to your tree? Thanks,

Ronald