From: Oliver Neukum <oliver@neukum.org>
To: Benjamin LaHaise <bcrl@kvack.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH]micro optimization of kcalloc
Date: Mon, 20 Mar 2006 16:33:29 +0100 [thread overview]
Message-ID: <200603201633.29532.oliver@neukum.org> (raw)
In-Reply-To: <20060320151433.GE16108@kvack.org>
Am Montag, 20. März 2006 16:14 schrieb Benjamin LaHaise:
> On Mon, Mar 20, 2006 at 03:45:23PM +0100, Oliver Neukum wrote:
> > static inline void *kcalloc(size_t n, size_t size, gfp_t flags)
> > {
> > - if (n != 0 && size > INT_MAX / n)
> > + if (unlikely(size != 0 && n > INT_MAX / size ))
> > return NULL;
> > return kzalloc(n * size, flags);
> > }
>
> This function shouldn't be inlined. We have no need to optimize the
> unlikely case like this.
The likely case is passing constants. Without inlining precisely the
likely case cannot be optimised.
Regards
Oliver
next prev parent reply other threads:[~2006-03-20 15:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-20 14:45 Oliver Neukum
2006-03-20 15:14 ` Benjamin LaHaise
2006-03-20 15:33 ` Oliver Neukum [this message]
2006-03-20 15:32 ` Benjamin LaHaise
2006-03-20 16:15 ` Pekka Enberg
2006-03-20 18:44 ` David Lang
2006-03-22 5:40 ` Valdis.Kletnieks
2006-03-20 15:37 ` Pekka Enberg
2006-03-20 15:51 ` Pekka Enberg
-- strict thread matches above, loose matches on Subject: below --
2006-03-20 13:08 Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200603201633.29532.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=bcrl@kvack.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®