From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Oliver Neukum" <neukum@fachschaft.cup.uni-muenchen.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH]micro optimization of kcalloc
Date: Mon, 20 Mar 2006 17:37:46 +0200 [thread overview]
Message-ID: <84144f020603200737ra799407o29f902907e00cc2d@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0603201542250.17461@fachschaft.cup.uni-muenchen.de>
On 3/20/06, Oliver Neukum <neukum@fachschaft.cup.uni-muenchen.de> wrote:
> --- linux-2.6.16-rc6-vanilla/include/linux/slab.h 2006-03-11 23:12:55.000000000 +0100
> +++ linux-2.6.16-rc6/include/linux/slab.h 2006-03-20 14:39:36.000000000 +0100
> @@ -118,7 +118,7 @@
> */
> static inline void *kcalloc(size_t n, size_t size, gfp_t flags)
> {
> - if (n != 0 && size > INT_MAX / n)
> + if (unlikely(size != 0 && n > INT_MAX / size ))
Please fix whitespace damage at the end.
Pekka
next prev parent reply other threads:[~2006-03-20 15:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-20 14:45 Oliver Neukum
2006-03-20 15:14 ` Benjamin LaHaise
2006-03-20 15:33 ` Oliver Neukum
2006-03-20 15:32 ` Benjamin LaHaise
2006-03-20 16:15 ` Pekka Enberg
2006-03-20 18:44 ` David Lang
2006-03-22 5:40 ` Valdis.Kletnieks
2006-03-20 15:37 ` Pekka Enberg [this message]
2006-03-20 15:51 ` Pekka Enberg
-- strict thread matches above, loose matches on Subject: below --
2006-03-20 13:08 Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020603200737ra799407o29f902907e00cc2d@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=neukum@fachschaft.cup.uni-muenchen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®