From: Nathan Scott <nathans@sgi.com>
To: Pekka J Enberg <penberg@cs.Helsinki.FI>
Cc: xfs-masters@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: kill kmem_zone init
Date: Tue, 21 Mar 2006 08:20:37 +1100 [thread overview]
Message-ID: <20060321082037.A653275@wobbly.melbourne.sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0603201501540.18684@sbz-30.cs.Helsinki.FI>; from penberg@cs.Helsinki.FI on Mon, Mar 20, 2006 at 03:04:14PM +0200
On Mon, Mar 20, 2006 at 03:04:14PM +0200, Pekka J Enberg wrote:
> Hi!
Hi Pekka,
> This patch changes kmem_zone_init() callers to use kmem_cache_alloc() so
> we can kill the wrapper.
Sorry, but thats just silly. Did you even look at the code
around what you're changing (it has to do more than just wrap
up slab calls)? So, NACK on this patch - it leaves the code
very confused (half zoney, half slaby), and is just unhelpful
code churn at the end of the day.
For your zalloc patch, you will need to duplicate the logic
in kmem_zone_alloc into kmem_zone_zalloc in order to use that
new zalloc interface you're introducing - which should be fine.
cheers.
--
Nathan
next prev parent reply other threads:[~2006-03-20 21:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-20 13:04 Pekka J Enberg
2006-03-20 21:20 ` Nathan Scott [this message]
2006-03-21 7:05 ` Pekka J Enberg
2006-03-21 21:55 ` [xfs-masters] " Nathan Scott
2006-03-22 7:37 ` Pekka J Enberg
2006-03-23 1:36 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060321082037.A653275@wobbly.melbourne.sgi.com \
--to=nathans@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.Helsinki.FI \
--cc=xfs-masters@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®