mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Chinner <dgc@sgi.com>
To: xfs-masters@oss.sgi.com
Cc: Nathan Scott <nathans@sgi.com>, linux-kernel@vger.kernel.org
Subject: Re: [xfs-masters] Re: [PATCH] xfs: kill kmem_zone init
Date: Thu, 23 Mar 2006 12:36:31 +1100	[thread overview]
Message-ID: <20060323013631.GF1173973@melbourne.sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0603220932230.27326@sbz-30.cs.Helsinki.FI>

On Wed, Mar 22, 2006 at 09:37:33AM +0200, Pekka J Enberg wrote:
> Would 
> you accept patches to convert code under PF_FSTRANS to use KM_NOFS so we 
> can kill the check in kmem_flags_convert()?

No.

XFS is full of code that can be called under both PF_FSTRANS and
!PF_FSTRANS contexts and hence recursion during allocation is
context dependent. Rather than pollute >20 call sites throughout XFS
with this check it got put in common code. Makes sense, yes?

Cheers,

Dave.
-- 
Dave Chinner
R&D Software Enginner
SGI Australian Software Group

      reply	other threads:[~2006-03-23  1:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-20 13:04 Pekka J Enberg
2006-03-20 21:20 ` Nathan Scott
2006-03-21  7:05   ` Pekka J Enberg
2006-03-21 21:55     ` [xfs-masters] " Nathan Scott
2006-03-22  7:37       ` Pekka J Enberg
2006-03-23  1:36         ` David Chinner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060323013631.GF1173973@melbourne.sgi.com \
    --to=dgc@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nathans@sgi.com \
    --cc=xfs-masters@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome