From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Ashok Raj <ashok.raj@intel.com>
Cc: akpm@osdl.org, Peter Williams <pwil3058@bigpond.net.au>,
Linus Torvalds <torvalds@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Pavel Machek <pavel@suse.cz>
Subject: Re: Linux v2.6.16
Date: Wed, 22 Mar 2006 19:11:05 +0100 [thread overview]
Message-ID: <200603221911.06576.rjw@sisk.pl> (raw)
In-Reply-To: <20060322095457.A12334@unix-os.sc.intel.com>
Hi,
On Wednesday 22 March 2006 18:54, Ashok Raj wrote:
> On Wed, Mar 22, 2006 at 06:39:41PM +0100, Rafael J. Wysocki wrote:
> > >
> > > Please consider for inclusion... resending with changelog per Andrew.
> >
> > Please don't apply this patch.
> >
> > CPU hotplug is used by swsusp for disabling the nonboot CPUs. Software
> > suspend won't work on SMP without CPU hotplugging.
> >
>
> Hi Rafael,
>
> what part of this is not suitable for swsusp? All we do is just use flat physical mode
> for IPI processing. The only difference is moving from logical flat mode to using
> flat physical mode.
>
> Have you tested swsusp with CONFIG_GENERICARCH and CONFIG_HOTPLUG_CPU=y ?
>
> It might help to explain why this would break your swsusp with SMP work?
On SMP systems swsusp (suspend in general, AFAICT) uses the disable_nonboot_cpus()
function defined in kernel/power/smp.c, which calls cpu_down() that is only
defined if CONFIG_HOTPLUG_CPU is set. We can't suspend and resume SMP systems
reliably without it.
Greetings,
Rafael
next prev parent reply other threads:[~2006-03-22 18:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-20 6:23 Linus Torvalds
2006-03-20 12:02 ` 2.6.16.x will be a long-living kernel series Adrian Bunk
2006-03-20 12:05 ` Arjan van de Ven
2006-03-20 12:12 ` Adrian Bunk
2006-03-20 13:03 ` Arjan van de Ven
2006-03-24 0:22 ` Adrian Bunk
2006-03-20 19:22 ` Jan Engelhardt
2006-03-20 17:19 ` Linux v2.6.16 Joe Korty
2006-03-20 19:04 ` Jeff Garzik
2006-03-20 19:25 ` Jan Engelhardt
2006-03-20 19:32 ` Joe Korty
2006-03-20 19:33 ` Linus Torvalds
2006-03-20 21:05 ` Andreas Schwab
2006-03-20 22:52 ` Matthias Andree
2006-03-22 5:22 ` Peter Williams
2006-03-22 6:31 ` Ashok Raj
2006-03-22 13:08 ` Ashok Raj
2006-03-22 13:25 ` Michal Piotrowski
2006-03-22 17:39 ` Rafael J. Wysocki
2006-03-22 17:54 ` Ashok Raj
2006-03-22 18:11 ` Rafael J. Wysocki [this message]
2006-03-22 18:27 ` Ashok Raj
2006-03-22 20:40 ` Rafael J. Wysocki
2006-03-22 21:00 ` Ashok Raj
2006-03-22 21:36 ` Rafael J. Wysocki
2006-03-22 22:27 ` Peter Williams
2006-03-28 16:39 ` Linux v2.6.16(.1) - compile failure Athanasius
2006-03-31 17:09 ` 'make oldconfig' sub-optimal 2.6.15 -> 2.6.16(.1) (was Re: Linux v2.6.16(.1) - compile failure) Athanasius
2006-04-01 9:18 ` netfilter: IP_NF_CONNTRACK_NETLINK=y, IP_NF_NAT=m compile error Adrian Bunk
[not found] <5Sm46-2a7-13@gated-at.bofh.it>
[not found] ` <5T455-7j-11@gated-at.bofh.it>
[not found] ` <5T5aR-1DN-23@gated-at.bofh.it>
[not found] ` <5Tbgl-2dp-43@gated-at.bofh.it>
2006-03-23 0:05 ` Linux v2.6.16 Bodo Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200603221911.06576.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@osdl.org \
--cc=ashok.raj@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=pwil3058@bigpond.net.au \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®