Re: Linux v2.6.16

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Wednesday 22 March 2006 22:00, Ashok Raj wrote:
> On Wed, Mar 22, 2006 at 09:40:00PM +0100, Rafael J. Wysocki wrote:
> > > 
> > > with that patch, try
> > > 
> > > CONFIG_X86_PC=n
> > > CONFIG_GENERICARCH=y
> > > CONFIG_HOTPLUG_CPU=y
> > 
> > Well, there's nothing like CONFIG_GENERICARCH on x86_64 or I'm obviously
> > missing something. :-)
> > 
> > On x86_64 I can choose between X86_PC and X86_VSMP and I'm not sure I'd like
> > to set X86_VSMP just in order to be able to suspend a box with a dual-core CPU.
> > IMHO that would be over the top.
> > 
> 
> This change is only for i386.. check the patch, its introduced only for arch/i386/Kconfig

Of course you're right, sorry.

> There is no change to x86_64, we anyway choose physflat mode in x86_64 which is exactly 
> same as bigsmp in i386.
> 
> We didnt change anything in x86_64...Why this speculation :(
> 
> Iam attaching that patch for your reference here... in case you lost it and looking at 
> some other patch. :-)
> 
> Could you _please_ really check this and tell me if there is real concern... 

No, there's not.  [Except I think we'll need to document that CONFIG_GENERICARCH
is needed for suspend on i386 SMP machines.]

> its pretty simple patch... no other arch is affected...

OK

Rafael