mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
	emin ak <eminak71@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: 2.6.16-rt10 crash on ppc
Date: Thu, 30 Mar 2006 09:23:39 +0200	[thread overview]
Message-ID: <20060330072339.GB3941@elte.hu> (raw)
In-Reply-To: <F86880BD-2EE9-4078-AB28-F769EF507C3B@kernel.crashing.org>


* Kumar Gala <galak@kernel.crashing.org> wrote:

> The issue me actually be a driver interrupt locking bug.  The driver 
> supports three distinct interrupts for TX, RX, Error.  I asked Emin to 
> try changing the driver to use SA_INTERRUPT in the request_irq() to 
> see what happens.  I believe that when he did that it worked but hurts 
> performance.

this is the -rt kernel, with PREEMPT_RT enabled, so SA_INTERRUPT should 
make no difference. All interrupts are executed by their interrupt 
thread, and are fully preemptible:

fastcall int handle_IRQ_event(unsigned int irq, struct pt_regs *regs,
                                struct irqaction *action)
{
        int ret, retval = 0, status = 0;

        /*
         * Unconditionally enable interrupts for threaded
         * IRQ handlers:
         */
        if (!hardirq_count() || !(action->flags & SA_INTERRUPT))
                local_irq_enable();

i.e. SA_INTERRUPT should have no effect.

	Ingo

  reply	other threads:[~2006-03-30  7:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-27 14:56 emin ak
2006-03-27 17:11 ` emin ak
2006-03-27 20:31 ` emin ak
2006-03-28  1:21   ` Nick Piggin
2006-03-29 15:08     ` Ingo Molnar
2006-03-30  2:55       ` Nick Piggin
2006-03-30  7:13         ` Ingo Molnar
2006-03-30  7:18           ` Kumar Gala
2006-03-30  7:23             ` Ingo Molnar [this message]
2006-03-30 10:25               ` emin ak
2006-03-30 11:34                 ` Ingo Molnar
2006-03-30 14:55                   ` emin ak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060330072339.GB3941@elte.hu \
    --to=mingo@elte.hu \
    --cc=eminak71@gmail.com \
    --cc=galak@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickpiggin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®