mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kumar Gala <galak@kernel.crashing.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
	emin ak <eminak71@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: 2.6.16-rt10 crash on ppc
Date: Thu, 30 Mar 2006 01:18:58 -0600	[thread overview]
Message-ID: <F86880BD-2EE9-4078-AB28-F769EF507C3B@kernel.crashing.org> (raw)
In-Reply-To: <20060330071322.GA3137@elte.hu>


On Mar 30, 2006, at 1:13 AM, Ingo Molnar wrote:

>
> * Nick Piggin <nickpiggin@yahoo.com.au> wrote:
>
>> Yes, that patch is basically what I had in mind.
>>
>> Is -rt ever allocating memory from really-hard-don't-preempt-me
>> context? I guess not, unless the zone->lock is one of those locks  
>> too,
>> right?
>
> no. zone->lock (and all the slab locks, and all the other MM locks)  
> are
> fully preemptible too.
>
>> Should you add a
>>
>>  #else
>>     BUG_ON(_really_dont_preempt_me());
>>  #endif
>>
>> just for safety, or will such misusage get caught elsewhere (eg. when
>> attempting to take zone->lock).
>
> it should be caught immediately, by the cond_resched().

The issue me actually be a driver interrupt locking bug.  The driver  
supports three distinct interrupts for TX, RX, Error.  I asked Emin  
to try changing the driver to use SA_INTERRUPT in the request_irq()  
to see what happens.  I believe that when he did that it worked but  
hurts performance.

- kumar

  reply	other threads:[~2006-03-30  7:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-27 14:56 emin ak
2006-03-27 17:11 ` emin ak
2006-03-27 20:31 ` emin ak
2006-03-28  1:21   ` Nick Piggin
2006-03-29 15:08     ` Ingo Molnar
2006-03-30  2:55       ` Nick Piggin
2006-03-30  7:13         ` Ingo Molnar
2006-03-30  7:18           ` Kumar Gala [this message]
2006-03-30  7:23             ` Ingo Molnar
2006-03-30 10:25               ` emin ak
2006-03-30 11:34                 ` Ingo Molnar
2006-03-30 14:55                   ` emin ak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F86880BD-2EE9-4078-AB28-F769EF507C3B@kernel.crashing.org \
    --to=galak@kernel.crashing.org \
    --cc=eminak71@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=nickpiggin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®