* [2.6.16-mm2 patch] don't awaken RT tasks on expired array
@ 2006-03-31 9:18 Mike Galbraith
2006-03-31 9:31 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Mike Galbraith @ 2006-03-31 9:18 UTC (permalink / raw)
To: Andrew Morton, Ingo Molnar; +Cc: lkml
RT tasks are being awakened on the expired array when expired_starving()
is true, whereas they really should be excluded. Fix below.
Signed-off-by: Mike Galbraith <efault@gmx.de>
--- linux-2.6.16-mm2/kernel/sched.c.org 2006-03-31 09:56:37.000000000 +0200
+++ linux-2.6.16-mm2/kernel/sched.c 2006-03-31 10:01:54.000000000 +0200
@@ -820,7 +820,7 @@
{
prio_array_t *target = rq->active;
- if (unlikely(batch_task(p) || expired_starving(rq)))
+ if (unlikely(batch_task(p) || (expired_starving(rq) && !rt_task(p))))
target = rq->expired;
enqueue_task(p, target);
inc_nr_running(p, rq);
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [2.6.16-mm2 patch] don't awaken RT tasks on expired array
2006-03-31 9:18 [2.6.16-mm2 patch] don't awaken RT tasks on expired array Mike Galbraith
@ 2006-03-31 9:31 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2006-03-31 9:31 UTC (permalink / raw)
To: Mike Galbraith; +Cc: Andrew Morton, lkml
* Mike Galbraith <efault@gmx.de> wrote:
> RT tasks are being awakened on the expired array when
> expired_starving() is true, whereas they really should be excluded.
> Fix below.
>
> Signed-off-by: Mike Galbraith <efault@gmx.de>
indeed, good catch.
Acked-by: Ingo Molnar <mingo@elte.hu>
> --- linux-2.6.16-mm2/kernel/sched.c.org 2006-03-31 09:56:37.000000000 +0200
> +++ linux-2.6.16-mm2/kernel/sched.c 2006-03-31 10:01:54.000000000 +0200
> @@ -820,7 +820,7 @@
> {
> prio_array_t *target = rq->active;
[nit: please use -p when generating patches. If you are using quilt you
can use QUILT_DIFF_OPTS="-p" in your .bashrc, and do 'quilt diff
--no-timestamps --sort' to get pretty patch output.]
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-03-31 9:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-03-31 9:18 [2.6.16-mm2 patch] don't awaken RT tasks on expired array Mike Galbraith
2006-03-31 9:31 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome