[patch 1/1] selinux: Fix MLS compatibility off-by-one bug

[patch 1/1] selinux: Fix MLS compatibility off-by-one bug

[Stephen Smalley]

From:  Ron Yorston <rmy@tigress.co.uk>

This patch fixes an off-by-one error in the MLS compatibility code
that was causing contexts with a MLS suffix to be rejected, preventing
sharing partitions between FC4 and FC5.  Bug reported in  
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188068
Please apply, for 2.6.17 if possible.

Signed-off-by: Stephen Smalley <sds@tycho.nsa.gov>
Acked-by:  James Morris <jmorris@redhat.com>

---

 security/selinux/ss/mls.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.16/security/selinux/ss/mls.c.selinux-debug	2006-04-06 19:47:15.000000000 +0100
+++ linux-2.6.16/security/selinux/ss/mls.c	2006-04-06 19:47:24.000000000 +0100
@@ -264,7 +264,7 @@ int mls_context_to_sid(char oldc,
 
 	if (!selinux_mls_enabled) {
 		if (def_sid != SECSID_NULL && oldc)
-			*scontext += strlen(*scontext);
+			*scontext += strlen(*scontext)+1;
 		return 0;
 	}
 

-- 
Stephen Smalley
National Security Agency

Re: [patch 1/1] selinux: Fix MLS compatibility off-by-one bug

[Andrew Morton]

Stephen Smalley <sds@tycho.nsa.gov> wrote:
>
> This patch fixes an off-by-one error in the MLS compatibility code
> that was causing contexts with a MLS suffix to be rejected, preventing
> sharing partitions between FC4 and FC5.  Bug reported in  
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188068
> Please apply, for 2.6.17 if possible.

Is this appropriate to 2.6.16.x?

Re: [patch 1/1] selinux: Fix MLS compatibility off-by-one bug

[Stephen Smalley]

On Tue, 2006-04-11 at 15:07 -0700, Andrew Morton wrote:
> Stephen Smalley <sds@tycho.nsa.gov> wrote:
> >
> > This patch fixes an off-by-one error in the MLS compatibility code
> > that was causing contexts with a MLS suffix to be rejected, preventing
> > sharing partitions between FC4 and FC5.  Bug reported in  
> > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188068
> > Please apply, for 2.6.17 if possible.
> 
> Is this appropriate to 2.6.16.x?

Yes, it seems to meet the criteria.
   
-- 
Stephen Smalley
National Security Agency