From: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
To: Peter Williams <pwil3058@bigpond.net.au>
Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
Andrew Morton <akpm@osdl.org>,
"Chen, Kenneth W" <kenneth.w.chen@intel.com>,
Con Kolivas <kernel@kolivas.org>, Ingo Molnar <mingo@elte.hu>,
Mike Galbraith <efault@gmx.de>,
Nick Piggin <nickpiggin@yahoo.com.au>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: smpnice: issues with finding busiest queue
Date: Thu, 13 Apr 2006 17:31:04 -0700 [thread overview]
Message-ID: <20060413173104.B15723@unix-os.sc.intel.com> (raw)
In-Reply-To: <443D95DF.2090807@bigpond.net.au>; from pwil3058@bigpond.net.au on Thu, Apr 13, 2006 at 10:05:51AM +1000
On Thu, Apr 13, 2006 at 10:05:51AM +1000, Peter Williams wrote:
>
> There be dragons here :-(.
>
At more places in this part of the world (smpnice) :)
We need to relook at find_busiest_queue()... With the current weighted
calculations, it doesn't always make sense to look at the highest weighted
runqueue in the busy group..
for example on a DP with HT system, how does the load balance behave with
Package-0 containing one high priority and one low priority, Package-1
containing one low priority(with other thread being idle)..
Package-1 thinks that it need to take the low priority thread from Package-0.
And find_busiest_queue() returns the cpu thread with highest priority task..
And ultimately(with help of active load balance) we move high priority
task to Package-1. And same continues with Package-0 now, moving high priority
task from package-1 to package-0..
Even without the presence of active load balance, load balance will fail
to balance(having two low priority tasks on one package, and high
priority task on another package) the above scenario....
We probably need to use imbalance(and more factors) to determine the busiest
queue in the group.....
thanks,
suresh
next prev parent reply other threads:[~2006-04-14 0:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-10 6:45 [PATCH] sched: move enough load to balance average load per task Peter Williams
2006-04-11 1:12 ` Siddha, Suresh B
2006-04-11 1:57 ` Peter Williams
2006-04-11 5:47 ` Siddha, Suresh B
2006-04-11 23:46 ` Peter Williams
2006-04-12 1:57 ` Siddha, Suresh B
2006-04-12 5:06 ` Peter Williams
2006-04-12 16:55 ` Siddha, Suresh B
2006-04-12 23:13 ` Peter Williams
[not found] ` <443D95DF.2090807@bigpond.net.au>
2006-04-14 0:31 ` Siddha, Suresh B [this message]
2006-04-14 1:17 ` smpnice: issues with finding busiest queue Peter Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060413173104.B15723@unix-os.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=akpm@osdl.org \
--cc=efault@gmx.de \
--cc=kenneth.w.chen@intel.com \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nickpiggin@yahoo.com.au \
--cc=pwil3058@bigpond.net.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome