mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] invert irq/migration.c brach prediction
@ 2006-04-21  6:06 Daniel Walker
  0 siblings, 0 replies; only message in thread
From: Daniel Walker @ 2006-04-21  6:06 UTC (permalink / raw)
  To: akpm; +Cc: linux-kernel

	If you get to that point in the code it means that 
desc->move_irq is set, pending_irq_cpumask[irq] and cpu_online_map 
should have a value. Still pretty good chance anding those two 
you'll still have a value. So these two branch predictors should
be inverted .

Signed-Off-By: Daniel Walker <dwalker@mvista.com>

Index: linux-2.6.16/kernel/irq/migration.c
===================================================================
--- linux-2.6.16.orig/kernel/irq/migration.c
+++ linux-2.6.16/kernel/irq/migration.c
@@ -30,7 +30,7 @@ void move_native_irq(int irq)
 
 	desc->move_irq = 0;
 
-	if (likely(cpus_empty(pending_irq_cpumask[irq])))
+	if (unlikely(cpus_empty(pending_irq_cpumask[irq])))
 		return;
 
 	if (!desc->handler->set_affinity)
@@ -49,7 +49,7 @@ void move_native_irq(int irq)
 	 * cause some ioapics to mal-function.
 	 * Being paranoid i guess!
 	 */
-	if (unlikely(!cpus_empty(tmp))) {
+	if (likely(!cpus_empty(tmp))) {
 		if (likely(!(desc->status & IRQ_DISABLED)))
 			desc->handler->disable(irq);
 

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-04-21  6:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-04-21  6:06 [PATCH] invert irq/migration.c brach prediction Daniel Walker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®