Re: acpi hotkey sysfs support

Re: acpi hotkey sysfs support

[Pavel Machek]

Hi!

> I have created a place under sysfs to have a unified place
> to gather user input for common hotkey features. 
> http://bugzilla.kernel.org/show_bug.cgi?id=5749#c10
> 
> All of you are owner of a specific acpi hotkey driver. 
> Would you like to use that sysfs support to reduce the
> unnecessary interface complexity.

Yep, patch looks okay. It would be nice to format it linux-like,
through. Space between if and (, and such stuff.

SHOUTING_TYPEDEFS look bad to me, too.
							Pavel
-- 
Thanks for all the (sleeping) penguins.

Re: acpi hotkey sysfs support

[Pavel Machek]

HI!

> > I have created a place under sysfs to have a unified place
> > to gather user input for common hotkey features. 
> > http://bugzilla.kernel.org/show_bug.cgi?id=5749#c10
> > 
> > All of you are owner of a specific acpi hotkey driver. 
> > Would you like to use that sysfs support to reduce the
> > unnecessary interface complexity.
> 
> Yep, patch looks okay. It would be nice to format it linux-like,
> through. Space between if and (, and such stuff.
> 
> SHOUTING_TYPEDEFS look bad to me, too.

One more thing... can we use input api for these events? Routing
buttons through /proc/acpi/event was mistake from day 0 :-(.

							Pavel

-- 
Thanks for all the (sleeping) penguins.

RE: acpi hotkey sysfs support

[Yu, Luming]

Hi Garrett,

Since you have provided generic backlight support for ASUS/IBM/Toshiba
acpi driver, which can reduce the unnecessary interface complexity in
platform specific acpi driver for brightness control, do you plan to do
same
thing for Ouptput switch, sound volume control..?  Moreover, do you
think the proposal below still make sense?

--Luming
 
>Subject: acpi hotkey sysfs support
>
>Hello all,
>
>I have created a place under sysfs to have a unified place
>to gather user input for common hotkey features. 
>http://bugzilla.kernel.org/show_bug.cgi?id=5749#c10
>
>All of you are owner of a specific acpi hotkey driver. 
>Would you like to use that sysfs support to reduce the
>unnecessary interface complexity.
>
>Thanks a lot
>Luming
>-

acpi hotkey sysfs support

[Yu, Luming]

Hello all,

I have created a place under sysfs to have a unified place
to gather user input for common hotkey features. 
http://bugzilla.kernel.org/show_bug.cgi?id=5749#c10

All of you are owner of a specific acpi hotkey driver. 
Would you like to use that sysfs support to reduce the
unnecessary interface complexity.

Thanks a lot
Luming