From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Heiko J Schick <schihei@de.ibm.com>
Cc: openib-general@openib.org, Christoph Raisch <RAISCH@de.ibm.com>,
Hoang-Nam Nguyen <HNGUYEN@de.ibm.com>,
Marcus Eder <MEDER@de.ibm.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 10/16] ehca: event queue
Date: Thu, 27 Apr 2006 13:48:28 +0200 [thread overview]
Message-ID: <20060427114828.GC32127@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <4450A1AD.7040506@de.ibm.com>
On Thu, 27 April 2006 12:49:17 +0200, Heiko J Schick wrote:
>
> + ret = hipz_h_alloc_resource_eq(shca->ipz_hca_handle,
Indentation?
> + &eq->pf,
> + type,
> + length,
> + &eq->ipz_eq_handle,
> + &eq->length,
> + &nr_pages, &eq->ist);
> +
> + if (ret != H_SUCCESS) {
Common convention is to return 0 on success and -ESOMETHING on eror.
You might want to follow that and remove H_SUCCESS from the complete
code.
> + if (!(vpage = ipz_qpageit_get_inc(&eq->ipz_queue))) {
I personally despise assignments in conditionals. Not sure if this is
documented in CodingStyle, but IME most kernel hackers tend to dislike
it as well.
Jörn
--
Don't patch bad code, rewrite it.
-- Kernigham and Pike, according to Rusty
next prev parent reply other threads:[~2006-04-27 11:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-27 10:49 Heiko J Schick
2006-04-27 11:48 ` Jörn Engel [this message]
2006-04-27 22:55 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060427114828.GC32127@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=HNGUYEN@de.ibm.com \
--cc=MEDER@de.ibm.com \
--cc=RAISCH@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=openib-general@openib.org \
--cc=schihei@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®