From: Segher Boessenkool <segher@kernel.crashing.org>
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: Heiko J Schick <schihei@de.ibm.com>,
linux-kernel@vger.kernel.org, openib-general@openib.org,
linuxppc-dev@ozlabs.org, Christoph Raisch <RAISCH@de.ibm.com>,
Hoang-Nam Nguyen <HNGUYEN@de.ibm.com>,
Marcus Eder <MEDER@de.ibm.com>
Subject: Re: [PATCH 10/16] ehca: event queue
Date: Fri, 28 Apr 2006 00:55:10 +0200 [thread overview]
Message-ID: <6C0D7610-D6A3-43CC-9327-926948167D43@kernel.crashing.org> (raw)
In-Reply-To: <20060427114828.GC32127@wohnheim.fh-wedel.de>
>> + if (ret != H_SUCCESS) {
>
> Common convention is to return 0 on success and -ESOMETHING on eror.
> You might want to follow that and remove H_SUCCESS from the complete
> code.
This return code doesn't come from anywhere within the kernel, though.
If we change this, we should get rid of _every_ #define bladibla 0
Do we want that? (I do ;-) )
>> + if (!(vpage = ipz_qpageit_get_inc(&eq->ipz_queue))) {
>
> I personally despise assignments in conditionals. Not sure if this is
> documented in CodingStyle, but IME most kernel hackers tend to dislike
> it as well.
In this case it's obvious; put it on a separate line.
Segher
prev parent reply other threads:[~2006-04-27 22:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-27 10:49 Heiko J Schick
2006-04-27 11:48 ` Jörn Engel
2006-04-27 22:55 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6C0D7610-D6A3-43CC-9327-926948167D43@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=HNGUYEN@de.ibm.com \
--cc=MEDER@de.ibm.com \
--cc=RAISCH@de.ibm.com \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=openib-general@openib.org \
--cc=schihei@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®