[PATCH -mm] W1_CON: add W1 to depends

[PATCH -mm] W1_CON: add W1 to depends

[Randy.Dunlap]

From: Randy Dunlap <rdunlap@xenotime.net>

W1_CON should depend on W1 also.

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
 drivers/w1/Kconfig |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.17-rc1-mm3.orig/drivers/w1/Kconfig
+++ linux-2.6.17-rc1-mm3/drivers/w1/Kconfig
@@ -13,7 +13,7 @@ config W1
 	  will be called wire.ko.
 
 config W1_CON
-	depends on CONNECTOR
+	depends on CONNECTOR && W1
 	bool "Userspace communication over connector"
 	default y
 	--- help ---


---

Re: [PATCH -mm] W1_CON: add W1 to depends

[Evgeniy Polyakov]

On Wed, Apr 26, 2006 at 09:21:31PM -0700, Randy.Dunlap (rdunlap@xenotime.net) wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
> 
> W1_CON should depend on W1 also.

I have no problem with the patch, but does dependency absence introduce
some problems? This config option is only used when w1 is enabled.

-- 
	Evgeniy Polyakov

Re: [PATCH -mm] W1_CON: add W1 to depends

[Randy.Dunlap]

On Thu, 27 Apr 2006 16:57:45 +0400 Evgeniy Polyakov wrote:

> On Wed, Apr 26, 2006 at 09:21:31PM -0700, Randy.Dunlap (rdunlap@xenotime.net) wrote:
> > From: Randy Dunlap <rdunlap@xenotime.net>
> > 
> > W1_CON should depend on W1 also.
> 
> I have no problem with the patch, but does dependency absence introduce
> some problems? This config option is only used when w1 is enabled.

Not quite true, or I wouldn't have seen a problem and sent a patch
for it.
With W1 disabled and doing 'make oldconfig', I got a prompt for

  Userspace communication over connector (W1_CON)? [Y/m/n]

which shouldn't happen.

---
~Randy

Re: [PATCH -mm] W1_CON: add W1 to depends

[Evgeniy Polyakov]

On Thu, Apr 27, 2006 at 08:25:25AM -0700, Randy.Dunlap (rdunlap@xenotime.net) wrote:
> On Thu, 27 Apr 2006 16:57:45 +0400 Evgeniy Polyakov wrote:
> 
> > On Wed, Apr 26, 2006 at 09:21:31PM -0700, Randy.Dunlap (rdunlap@xenotime.net) wrote:
> > > From: Randy Dunlap <rdunlap@xenotime.net>
> > > 
> > > W1_CON should depend on W1 also.
> > 
> > I have no problem with the patch, but does dependency absence introduce
> > some problems? This config option is only used when w1 is enabled.
> 
> Not quite true, or I wouldn't have seen a problem and sent a patch
> for it.
> With W1 disabled and doing 'make oldconfig', I got a prompt for
> 
>   Userspace communication over connector (W1_CON)? [Y/m/n]
> 
> which shouldn't happen.

I mean that it is asked to be enabled or not, but some compilation and
other logic is only turned on when w1 is enabled.

But you are right, it should not appear if w1 is not enabled.
I will take care of your patch, thank you, Randy.

> ---
> ~Randy

-- 
	Evgeniy Polyakov