mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
To: akpm@osdl.org
Cc: a.zummo@towertech.it, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RTC: rtc-dev UIE emulation
Date: Sun, 30 Apr 2006 00:10:03 +0900 (JST)	[thread overview]
Message-ID: <20060430.001003.52129547.anemo@mba.ocn.ne.jp> (raw)
In-Reply-To: <20060428232306.5049c30d.akpm@osdl.org> <20060429093108.77ced705@inspiron>

Thanks for your detailed review, Andrew.  Basically I just merged
genrtc's stuff, but obviously it seems there are lots of things to
fix/refine/improve.  I'll try to do but it will take some times.

Alessandro, following comments are against for this patch, right?

On Sat, 29 Apr 2006 09:31:08 +0200, Alessandro Zummo <alessandro.zummo@towertech.it> wrote:
>   this patch will conflict with rtc drivers that have proper UIE
>  support, please remove it from the tree.
> 
>   A generic UIE emulation should at least check if the ioctl
>  has not been already handled by the underlaying rtc driver.
> 
>   That means that every driver should be modified to return
>  -ENOIOCTLCMD if it gets passed an unknown IOCTL and that
>  this patch should check for this code before trying to emulate.

Since rtc_dev_ioctl() calls underlaying rtc driver's ioctl() first and
checks -EINVAL, so I think it will not conflict.  Is it wrong?

---
Atsushi Nemoto

  parent reply	other threads:[~2006-04-29 15:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-28 16:16 Atsushi Nemoto
2006-04-29  6:23 ` Andrew Morton
     [not found]   ` <20060429093108.77ced705@inspiron>
2006-04-29 15:10     ` Atsushi Nemoto [this message]
2006-05-01 14:32       ` Atsushi Nemoto
2006-05-02 20:15         ` Alessandro Zummo
2006-05-03 16:43           ` Atsushi Nemoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060430.001003.52129547.anemo@mba.ocn.ne.jp \
    --to=anemo@mba.ocn.ne.jp \
    --cc=a.zummo@towertech.it \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®