From: Alessandro Zummo <alessandro.zummo@towertech.it>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: akpm@osdl.org, a.zummo@towertech.it, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RTC: rtc-dev UIE emulation
Date: Tue, 2 May 2006 22:15:35 +0200 [thread overview]
Message-ID: <20060502221535.01692c24@inspiron> (raw)
In-Reply-To: <20060501.233242.59466338.anemo@mba.ocn.ne.jp>
On Mon, 01 May 2006 23:32:42 +0900 (JST)
Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> Here is an updated patch. I think this one reflects all suggestions
> by Andrew.
seems ok to me, just a few comments:
> + driver did not provides RTC_UIE ioctls. RTC_UIE is required
> + by some programs, such as hwclock.
please fix the double spacing and s/provides/provide/
hwclock will be fixed to not rely on uie anymore anyway.
> +#ifdef CONFIG_RTC_INTF_DEV_UIE_EMUL
> + INIT_WORK(&rtc->uie_task, rtc_uie_task, rtc);
> + setup_timer(&rtc->uie_timer, rtc_uie_timer, (unsigned long)rtc);
> + rtc->irq_active = 0;
> + rtc->stop_uie_polling = 0;
> + rtc->uie_task_active = 0;
> + rtc->uie_timer_active = 0;
> +#endif
the rtc struct is allocated via kzalloc, so
you don't need to zero it.
--
Best regards,
Alessandro Zummo,
Tower Technologies - Turin, Italy
http://www.towertech.it
next prev parent reply other threads:[~2006-05-02 20:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-28 16:16 Atsushi Nemoto
2006-04-29 6:23 ` Andrew Morton
[not found] ` <20060429093108.77ced705@inspiron>
2006-04-29 15:10 ` Atsushi Nemoto
2006-05-01 14:32 ` Atsushi Nemoto
2006-05-02 20:15 ` Alessandro Zummo [this message]
2006-05-03 16:43 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060502221535.01692c24@inspiron \
--to=alessandro.zummo@towertech.it \
--cc=a.zummo@towertech.it \
--cc=akpm@osdl.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®