[patch 2.6.17-rc3] smsc-ircc2, minimal PNP hotplug support

[patch 2.6.17-rc3] smsc-ircc2, minimal PNP hotplug support

[David Brownell]

[-- Attachment #1: Type: text/plain, Size: 39 bytes --]

An old laptop now behaves more sanely.

[-- Attachment #2: ir-smsc.patch --]
[-- Type: text/x-diff, Size: 1317 bytes --]

Minimal PNP hotplug support for the smsc-ircc2 driver.  A modular driver
will be modprobed via hotplug, but still bypasses driver model probing.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

Index: linux/drivers/net/irda/smsc-ircc2.c
===================================================================
--- linux.orig/drivers/net/irda/smsc-ircc2.c	2006-04-23 23:23:38.000000000 -0700
+++ linux/drivers/net/irda/smsc-ircc2.c	2006-04-28 21:42:14.000000000 -0700
@@ -54,6 +54,7 @@
 #include <linux/rtnetlink.h>
 #include <linux/serial_reg.h>
 #include <linux/dma-mapping.h>
+#include <linux/pnp.h>
 #include <linux/platform_device.h>
 
 #include <asm/io.h>
@@ -358,6 +360,16 @@
                iobase + IRCC_MASTER);
 }
 
+#ifdef	CONFIG_PNP
+/* PNP hotplug support */
+static const struct pnp_device_id smsc_ircc_pnp_table[] = {
+	{ .id = "SMCf010", .driver_data = 0 },
+	/* and presumably others */
+	{ }
+};
+MODULE_DEVICE_TABLE(pnp, smsc_ircc_pnp_table);
+#endif
+
 
 /*******************************************************************************
  *
@@ -2072,7 +2084,8 @@
 
 /* PROBING
  *
- *
+ * REVISIT we can be told about the device by PNP, and should use that info
+ * instead of probing hardware and creating a platform_device ...
  */
 
 static int __init smsc_ircc_look_for_chips(void)

Re: [patch 2.6.17-rc3] smsc-ircc2, minimal PNP hotplug support

[Jean Tourrilhes]

On Mon, May 01, 2006 at 01:13:43PM -0700, David Brownell wrote:
> An old laptop now behaves more sanely.

> Minimal PNP hotplug support for the smsc-ircc2 driver.  A modular driver
> will be modprobed via hotplug, but still bypasses driver model probing.
> 
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

	Hi,

	Samuel Ortiz <samuel.ortiz@nokia.com> is now in charge of IrDA.
	Thanks...

	Jean

> Index: linux/drivers/net/irda/smsc-ircc2.c
> ===================================================================
> --- linux.orig/drivers/net/irda/smsc-ircc2.c	2006-04-23 23:23:38.000000000 -0700
> +++ linux/drivers/net/irda/smsc-ircc2.c	2006-04-28 21:42:14.000000000 -0700
> @@ -54,6 +54,7 @@
>  #include <linux/rtnetlink.h>
>  #include <linux/serial_reg.h>
>  #include <linux/dma-mapping.h>
> +#include <linux/pnp.h>
>  #include <linux/platform_device.h>
>  
>  #include <asm/io.h>
> @@ -358,6 +360,16 @@
>                 iobase + IRCC_MASTER);
>  }
>  
> +#ifdef	CONFIG_PNP
> +/* PNP hotplug support */
> +static const struct pnp_device_id smsc_ircc_pnp_table[] = {
> +	{ .id = "SMCf010", .driver_data = 0 },
> +	/* and presumably others */
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(pnp, smsc_ircc_pnp_table);
> +#endif
> +
>  
>  /*******************************************************************************
>   *
> @@ -2072,7 +2084,8 @@
>  
>  /* PROBING
>   *
> - *
> + * REVISIT we can be told about the device by PNP, and should use that info
> + * instead of probing hardware and creating a platform_device ...
>   */
>  
>  static int __init smsc_ircc_look_for_chips(void)