[PATCH] 2.6 Altix : correct ioc3 port order

[PATCH] 2.6 Altix : correct ioc3 port order

[Pat Gefre]

Currently loading the ioc3 as a module will cause the ports to be
numbered in reverse order. This mod maintains the proper order of cards
for port numbering.


Signed-off-by: Patrick Gefre <pfg@sgi.com>


Index: linux-2.6/drivers/sn/ioc3.c
===================================================================
--- linux-2.6.orig/drivers/sn/ioc3.c	2006-04-28 13:56:38.000000000 -0500
+++ linux-2.6/drivers/sn/ioc3.c	2006-04-28 14:20:37.919756143 -0500
@@ -678,7 +678,7 @@
 	/* Track PCI-device specific data */
 	pci_set_drvdata(pdev, idd);
 	down_write(&ioc3_devices_rwsem);
-	list_add(&idd->list, &ioc3_devices);
+	list_add_tail(&idd->list, &ioc3_devices);
 	idd->id = ioc3_counter++;
 	up_write(&ioc3_devices_rwsem);
 

Re: [PATCH] 2.6 Altix : correct ioc3 port order

[Brent Casavant]

On Fri, 28 Apr 2006, Pat Gefre wrote:

> Currently loading the ioc3 as a module will cause the ports to be
> numbered in reverse order. This mod maintains the proper order of cards
> for port numbering.

Pat,

Since the sn/ioc3.c code came from sn/ioc4.c, do we have the same
problem there as well?

Brent

-- 
Brent Casavant                          All music is folk music.  I ain't
bcasavan@sgi.com                        never heard a horse sing a song.
Silicon Graphics, Inc.                    -- Louis Armstrong

Re: [PATCH] 2.6 Altix : correct ioc3 port order

[Brent Casavant]

On Fri, 28 Apr 2006, Pat Gefre wrote:

> Currently loading the ioc3 as a module will cause the ports to be
> numbered in reverse order. This mod maintains the proper order of cards
> for port numbering.

Here's the corresponding patch for IOC4.

Signed-off-by: Brent Casavant <bcasavan@sgi.com>

diff --git a/drivers/sn/ioc4.c b/drivers/sn/ioc4.c
index 67140a5..cdeff90 100644
--- a/drivers/sn/ioc4.c
+++ b/drivers/sn/ioc4.c
@@ -310,7 +310,7 @@ ioc4_probe(struct pci_dev *pdev, const s
        pci_set_drvdata(idd->idd_pdev, idd);

        mutex_lock(&ioc4_mutex);
-       list_add(&idd->idd_list, &ioc4_devices);
+       list_add_tail(&idd->idd_list, &ioc4_devices);

        /* Add this IOC4 to all submodules */
        list_for_each_entry(is, &ioc4_submodules, is_list) {

-- 
Brent Casavant                          All music is folk music.  I ain't
bcasavan@sgi.com                        never heard a horse sing a song.
Silicon Graphics, Inc.                    -- Louis Armstrong