From: Andrew Morton <akpm@osdl.org>
To: Latchesar Ionkov <lucho@ionkov.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] v9fs: signal handling fixes
Date: Wed, 10 May 2006 21:44:10 -0700 [thread overview]
Message-ID: <20060510214410.4d5bfa15.akpm@osdl.org> (raw)
In-Reply-To: <20060506191726.GB8063@ionkov.net>
Latchesar Ionkov <lucho@ionkov.net> wrote:
>
> + /* if the request is not sent yet, just remove it from the list */
> + list_for_each_entry_safe(rreq, rptr, &m->unsent_req_list, req_list) {
> + if (rreq->tag == req->tag) {
> + dprintk(DEBUG_MUX, "mux %p req %p request is not sent yet\n", m, req);
> + list_del(&rreq->req_list);
> + req->flush = Flushed;
> + spin_unlock(&m->lock);
> + if (req->cb)
> + (*req->cb) (req, req->cba);
> + return 0;
> + }
Actually, list_for_each() would suffice here - the code won't touch the
list again after having modified it.
next prev parent reply other threads:[~2006-05-11 4:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-06 19:17 Latchesar Ionkov
2006-05-11 4:44 ` Andrew Morton [this message]
2006-05-11 4:48 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060510214410.4d5bfa15.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®