mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Latchesar Ionkov <lucho@ionkov.net>
Cc: linux-kernel@vger.kernel.org,
	Eric Van Hensbergen <ericvh@ericvh.myip.org>
Subject: Re: [PATCH] v9fs: signal handling fixes
Date: Wed, 10 May 2006 21:48:41 -0700	[thread overview]
Message-ID: <20060510214841.17553cfe.akpm@osdl.org> (raw)
In-Reply-To: <20060506191726.GB8063@ionkov.net>

Latchesar Ionkov <lucho@ionkov.net> wrote:
>
> +	clear_thread_flag(TIF_SIGPENDING);

It is unusual and arguably inappropriate for a filesystem to be playing
with thread flags in this manner.

There are no comments in there explaining why this is happening (there
should be: unusual and surprising things should always be commented, no?)
so I must ask on a mailing list.

What's going on in there?

      parent reply	other threads:[~2006-05-11  4:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-06 19:17 Latchesar Ionkov
2006-05-11  4:44 ` Andrew Morton
2006-05-11  4:48 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060510214841.17553cfe.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=ericvh@ericvh.myip.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucho@ionkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®