From: Francois Romieu <romieu@fr.zoreil.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Daniel Walker <dwalker@mvista.com>,
akpm@osdl.org, edward_peng@dlink.com.tw, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dl2k: use explicit DMA_48BIT_MASK
Date: Thu, 11 May 2006 21:23:52 +0200 [thread overview]
Message-ID: <20060511192352.GA18200@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20060510235215.GC26617@us.ibm.com>
Jon Mason <jdmason@us.ibm.com> :
[...]
> DMA_*BIT_MASK is intended to be used in the DMA_API's checking of
> DMA controller's addressable memory, where as this is masking off the
> lower 48bits of a descriptor for its DMA address.
Imho it's the specific reason why the DMA_*BIT_MASK applies here: the
code is already in dma-"tainted" land.
> I think a better solution (which I should've done when I pushed the
> original patch) would be a driver specific #define.
$ find drivers -type f | xargs grep -i [^f]ffffffffffff[^f] | wc -l
12
No disagreement: it does not have a huge potential for code duplication.
--
Ueimor
next prev parent reply other threads:[~2006-05-11 19:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-10 18:12 [PATCH -mm] updated dl2k gcc 4.1 warning fix Daniel Walker
2006-05-10 18:57 ` [PATCH] dl2k: use explicit DMA_48BIT_MASK Francois Romieu
2006-05-10 23:52 ` Jon Mason
2006-05-11 19:23 ` Francois Romieu [this message]
2006-05-11 19:45 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060511192352.GA18200@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=akpm@osdl.org \
--cc=dwalker@mvista.com \
--cc=edward_peng@dlink.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®