From: Catalin Marinas <catalin.marinas@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH 2.6.17-rc4 6/6] Remove some of the kmemleak false positives
Date: Sat, 13 May 2006 17:06:25 +0100 [thread overview]
Message-ID: <20060513160625.8848.76947.stgit@localhost.localdomain> (raw)
In-Reply-To: <20060513155757.8848.11980.stgit@localhost.localdomain>
From: Catalin Marinas <catalin.marinas@arm.com>
There are allocations for which the main pointer cannot be found but they
are not memory leaks. This patch fixes some of them.
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
---
ipc/util.c | 13 +++++++++++++
kernel/params.c | 9 ++++++++-
2 files changed, 21 insertions(+), 1 deletions(-)
diff --git a/ipc/util.c b/ipc/util.c
index 8193299..788db50 100644
--- a/ipc/util.c
+++ b/ipc/util.c
@@ -31,6 +31,11 @@ #include <linux/seq_file.h>
#include <linux/proc_fs.h>
#include <linux/audit.h>
+#ifdef CONFIG_DEBUG_MEMLEAK
+#include <linux/memleak.h>
+#endif
+
+
#include <asm/unistd.h>
#include "util.h"
@@ -389,6 +394,10 @@ void* ipc_rcu_alloc(int size)
*/
if (rcu_use_vmalloc(size)) {
out = vmalloc(HDRLEN_VMALLOC + size);
+#ifdef CONFIG_DEBUG_MEMLEAK
+ /* avoid a false alarm. That's not a memory leak */
+ memleak_free(out);
+#endif
if (out) {
out += HDRLEN_VMALLOC;
container_of(out, struct ipc_rcu_hdr, data)->is_vmalloc = 1;
@@ -396,6 +405,10 @@ void* ipc_rcu_alloc(int size)
}
} else {
out = kmalloc(HDRLEN_KMALLOC + size, GFP_KERNEL);
+#ifdef CONFIG_DEBUG_MEMLEAK
+ /* avoid a false alarm. That's not a memory leak */
+ memleak_free(out);
+#endif
if (out) {
out += HDRLEN_KMALLOC;
container_of(out, struct ipc_rcu_hdr, data)->is_vmalloc = 0;
diff --git a/kernel/params.c b/kernel/params.c
index af43ecd..fb268e8 100644
--- a/kernel/params.c
+++ b/kernel/params.c
@@ -548,6 +548,7 @@ static void __init kernel_param_sysfs_se
unsigned int name_skip)
{
struct module_kobject *mk;
+ struct module_param_attrs *mp;
mk = kzalloc(sizeof(struct module_kobject), GFP_KERNEL);
BUG_ON(!mk);
@@ -557,11 +558,17 @@ static void __init kernel_param_sysfs_se
kobject_set_name(&mk->kobj, name);
kobject_register(&mk->kobj);
+ mp = param_sysfs_setup(mk, kparam, num_params, name_skip);
/* no need to keep the kobject if no parameter is exported */
- if (!param_sysfs_setup(mk, kparam, num_params, name_skip)) {
+ if (!mp) {
kobject_unregister(&mk->kobj);
kfree(mk);
}
+#ifdef CONFIG_DEBUG_MEMLEAK
+ /* avoid a false alarm. That's not a memory leak */
+ else
+ memleak_free(mp);
+#endif
}
/*
next prev parent reply other threads:[~2006-05-13 16:07 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-13 15:57 [RFC PATCH 2.6.17-rc4 0/6] Kernel memory leak detector Catalin Marinas
2006-05-13 16:05 ` [PATCH 2.6.17-rc4 1/6] Base support for kmemleak Catalin Marinas
2006-05-13 17:42 ` Jesper Juhl
2006-05-13 17:47 ` Roland Dreier
2006-05-14 7:24 ` Catalin Marinas
2006-05-14 17:32 ` Ingo Oeser
2006-05-15 10:15 ` Catalin Marinas
2006-05-13 18:11 ` Paul Jackson
2006-05-13 23:20 ` Andi Kleen
2006-05-14 8:19 ` Catalin Marinas
2006-05-15 9:15 ` Andi Kleen
2006-05-15 10:09 ` Catalin Marinas
2006-05-26 8:59 ` Ingo Molnar
2006-05-26 9:39 ` Andi Kleen
2006-05-26 11:31 ` Ingo Molnar
2006-05-26 16:37 ` Catalin Marinas
2006-05-26 17:47 ` Ingo Molnar
2006-05-26 21:49 ` Catalin Marinas
2006-05-26 22:01 ` Catalin Marinas
2006-05-14 14:53 ` Pekka Enberg
2006-05-14 15:30 ` Catalin Marinas
2006-05-14 15:52 ` Catalin Marinas
2006-05-13 16:05 ` [PATCH 2.6.17-rc4 2/6] Some documentation " Catalin Marinas
2006-05-13 16:06 ` [PATCH 2.6.17-rc4 3/6] Add the memory allocation/freeing hooks " Catalin Marinas
2006-05-14 14:49 ` Pekka Enberg
2006-05-13 16:06 ` [PATCH 2.6.17-rc4 4/6] Add kmemleak support for i386 Catalin Marinas
2006-05-13 18:24 ` Jesper Juhl
2006-05-13 21:20 ` Jan Engelhardt
2006-05-14 7:28 ` Catalin Marinas
2006-05-13 16:06 ` [PATCH 2.6.17-rc4 5/6] Add kmemleak support for ARM Catalin Marinas
2006-05-13 18:25 ` Jesper Juhl
2006-05-13 16:06 ` Catalin Marinas [this message]
2006-05-13 19:21 ` [PATCH 2.6.17-rc4 6/6] Remove some of the kmemleak false positives Jesper Juhl
2006-05-14 7:31 ` Catalin Marinas
2006-05-14 14:55 ` Pekka Enberg
2006-05-14 15:39 ` Catalin Marinas
2006-05-14 17:39 ` Ingo Oeser
2006-05-15 10:12 ` Catalin Marinas
2006-05-15 18:32 ` Ingo Oeser
2006-05-15 11:52 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060513160625.8848.76947.stgit@localhost.localdomain \
--to=catalin.marinas@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome