From: Ingo Oeser <ioe-lkml@rameria.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: akpm@osdl.org, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -mm] update comment in rtmutex.c and friends
Date: Sun, 14 May 2006 17:28:03 +0200 [thread overview]
Message-ID: <200605141728.05752.ioe-lkml@rameria.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0605131846250.2208@gandalf.stny.rr.com>
Hi Steven,
On Sunday, 14. May 2006 01:34, Steven Rostedt wrote:
> @@ -46,9 +46,15 @@
> *
> * The fast atomic compare exchange based acquire and release is only
> * possible when bit 0 and 1 of lock->owner are 0.
> + *
> + * (*) There's a small time where the owner can be NULL and the
> + * "lock has waiters" bit is set. This can happen when grabbing the lock.
> + * To prevent a cmpxchg of the owner releasing the lock, we need to set this
> + * bit before looking at the lock, hence the reason this is a transitional
> + * state.
> */
>
> -static void
> +static vid
Typo here.
> rt_mutex_set_owner(struct rt_mutex *lock, struct task_struct *owner,
> unsigned long mask)
> {
> @@ -365,6 +371,7 @@ static int try_to_take_rt_mutex(struct r
PS: Compile testing ANY changes to *.c and *.h files
will catch most obvious brown paper bag typos for you :-)
Regards
Ingo Oeser
next prev parent reply other threads:[~2006-05-14 15:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-13 23:34 Steven Rostedt
2006-05-13 23:39 ` Thomas Gleixner
2006-05-14 15:28 ` Ingo Oeser [this message]
2006-05-14 15:43 ` Andrew Morton
2006-05-14 16:04 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200605141728.05752.ioe-lkml@rameria.de \
--to=ioe-lkml@rameria.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®