mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jordan Crouse" <jordan.crouse@amd.com>
To: "Michael Buesch" <mb@bu3sch.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Add Geode HW RNG driver
Date: Mon, 15 May 2006 09:35:39 -0600	[thread overview]
Message-ID: <20060515153539.GB22239@cosmic.amd.com> (raw)
In-Reply-To: <200605122246.58961.mb@bu3sch.de>

On 12/05/06 22:46 +0200, "Michael Buesch" wrote:
> On Friday 12 May 2006 13:05, you wrote:
> > mb@bu3sch.de wrote:
> > > Signed-off-by: Michael Buesch <mb@bu3sch.de>
> > > Index: hwrng/drivers/char/hw_random/Kconfig
> > > ===================================================================
> > > --- hwrng.orig/drivers/char/hw_random/Kconfig	2006-05-08 00:11:59.000000000 +0200
> > > +++ hwrng/drivers/char/hw_random/Kconfig	2006-05-08 00:12:08.000000000 +0200
> > > @@ -35,3 +35,16 @@
> > >  	  module will be called amd-rng.
> > >  
> > >  	  If unsure, say Y.
> > > +
> > > +config HW_RANDOM_GEODE
> > > +	tristate "AMD Geode HW Random Number Generator support"
> > > +	depends on HW_RANDOM && (X86 || IA64) && PCI
> >                                      ^^^^^^^
> > IA64?
> 
> I have no idea. I neither wrote the driver, nor do I have the device.
> So, drop IA64?

Wow - where did that come from?  Yeah, drop it!

> > > +	default y
> > > +	---help---
> > > +	  This driver provides kernel-side support for the Random Number
> > > +	  Generator hardware found on AMD Geode based motherboards.
> > > +
> > > +	  To compile this driver as a module, choose M here: the
> > > +	  module will be called geode-rng.
> > 
> > You need to state which members of the Geode family have this hardware.
> >  e.g., Is it only the Geode LX CPUs?
> 
> Well, no idea. It was not stated in the existing old help text either.

Its just the Geode LX - that help text should be more specific in that
regard.

Regards,
Jordan

--
Jordan Crouse
Senior Linux Engineer
AMD - Personal Connectivity Solutions Group
<www.amd.com/embeddedprocessors>


  parent reply	other threads:[~2006-05-15 18:59 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-12 10:35 [patch 0/9] New Generic HW RNG (#3) mb
2006-05-12 10:35 ` [patch 1/9] Remove old HW RNG support mb
2006-05-12 10:35 ` [patch 2/9] Add new generic HW RNG core mb
2006-05-12 10:35 ` [patch 3/9] Add Intel HW RNG driver mb
2006-05-12 11:08   ` Sergey Vlasov
2006-05-12 20:48     ` Michael Buesch
2006-05-12 10:35 ` [patch 4/9] Add AMD " mb
2006-05-12 10:35 ` [patch 5/9] Add Geode " mb
2006-05-12 11:05   ` David Vrabel
2006-05-12 20:46     ` Michael Buesch
2006-05-12 21:06       ` David Vrabel
2006-05-15 15:35       ` Jordan Crouse [this message]
2006-05-12 10:35 ` [patch 6/9] Add VIA " mb
2006-05-12 10:35 ` [patch 7/9] Add ixp4xx " mb
2006-05-12 10:35 ` [patch 8/9] Add TI OMAP CPU family " mb
2006-05-12 10:35 ` [patch 9/9] Add bcm43xx HW RNG support mb
2006-05-12 15:16   ` Denis Vlasenko
2006-05-12 15:20     ` Johannes Berg
2006-05-12 20:51     ` Michael Buesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060515153539.GB22239@cosmic.amd.com \
    --to=jordan.crouse@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mb@bu3sch.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®