Re: [patch 5/9] Add Geode HW RNG driver

[David Vrabel <dvrabel@cantab.net>]

Michael Buesch wrote:
> On Friday 12 May 2006 13:05, you wrote:
>> mb@bu3sch.de wrote:
>>> Signed-off-by: Michael Buesch <mb@bu3sch.de>
>>> Index: hwrng/drivers/char/hw_random/Kconfig
>>> ===================================================================
>>> --- hwrng.orig/drivers/char/hw_random/Kconfig	2006-05-08 00:11:59.000000000 +0200
>>> +++ hwrng/drivers/char/hw_random/Kconfig	2006-05-08 00:12:08.000000000 +0200
>>> @@ -35,3 +35,16 @@
>>>  	  module will be called amd-rng.
>>>  
>>>  	  If unsure, say Y.
>>> +
>>> +config HW_RANDOM_GEODE
>>> +	tristate "AMD Geode HW Random Number Generator support"
>>> +	depends on HW_RANDOM && (X86 || IA64) && PCI
>>                                      ^^^^^^^
>> IA64?
> 
> I have no idea. I neither wrote the driver, nor do I have the device.
> So, drop IA64?

Yes, the AMD Geode CPUs are all x86.

>>> +	default y
>>> +	---help---
>>> +	  This driver provides kernel-side support for the Random Number
>>> +	  Generator hardware found on AMD Geode based motherboards.
>>> +
>>> +	  To compile this driver as a module, choose M here: the
>>> +	  module will be called geode-rng.
>> You need to state which members of the Geode family have this hardware.
>>  e.g., Is it only the Geode LX CPUs?
> 
> Well, no idea. It was not stated in the existing old help text either.

I checked the datasheets for the Geode GX, Geode LX and Geode NX and 
only the Geode LX has an on-chip random number generator.  So this 
driver must be for the Geode LX only.

David Vrabel