* [PATCH] Kdump i386 nmi event notification fix
@ 2006-05-15 17:48 Vivek Goyal
2006-05-16 18:15 ` Andi Kleen
0 siblings, 1 reply; 3+ messages in thread
From: Vivek Goyal @ 2006-05-15 17:48 UTC (permalink / raw)
To: Morton Andrew Morton, linux kernel mailing list, Fastboot mailing list
Cc: Andi Kleen, Don Zickus
o After a crash we should wait for NMI IPI event and not for external NMI
or NMI watchdog tick.
Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com>
---
linux-2.6.17-rc4-1M-vivek/arch/i386/kernel/crash.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff -puN arch/i386/kernel/crash.c~kdump-i386-nmi-event-notification-fix arch/i386/kernel/crash.c
--- linux-2.6.17-rc4-1M/arch/i386/kernel/crash.c~kdump-i386-nmi-event-notification-fix 2006-05-15 12:08:21.000000000 -0400
+++ linux-2.6.17-rc4-1M-vivek/arch/i386/kernel/crash.c 2006-05-15 13:25:09.000000000 -0400
@@ -102,7 +102,7 @@ static int crash_nmi_callback(struct not
struct pt_regs fixed_regs;
int cpu;
- if (val != DIE_NMI)
+ if (val != DIE_NMI_IPI)
return NOTIFY_OK;
regs = ((struct die_args *)data)->regs;
@@ -113,7 +113,7 @@ static int crash_nmi_callback(struct not
* an NMI if system was initially booted with nmi_watchdog parameter.
*/
if (cpu == crashing_cpu)
- return 1;
+ return NOTIFY_STOP;
local_irq_disable();
if (!user_mode_vm(regs)) {
_
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Kdump i386 nmi event notification fix
2006-05-15 17:48 [PATCH] Kdump i386 nmi event notification fix Vivek Goyal
@ 2006-05-16 18:15 ` Andi Kleen
2006-05-16 18:35 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Andi Kleen @ 2006-05-16 18:15 UTC (permalink / raw)
To: Vivek Goyal
Cc: Morton Andrew Morton, linux kernel mailing list,
Fastboot mailing list, Don Zickus
On Mon, May 15, 2006 at 01:48:35PM -0400, Vivek Goyal wrote:
>
>
> o After a crash we should wait for NMI IPI event and not for external NMI
> or NMI watchdog tick.
The two patches don't apply anymore after Don's big NMI rework.
Can you forward port and retest/resend please?
-Andi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Kdump i386 nmi event notification fix
2006-05-16 18:15 ` Andi Kleen
@ 2006-05-16 18:35 ` Andrew Morton
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2006-05-16 18:35 UTC (permalink / raw)
To: Andi Kleen; +Cc: vgoyal, linux-kernel, fastboot, dzickus
Andi Kleen <ak@muc.de> wrote:
>
> On Mon, May 15, 2006 at 01:48:35PM -0400, Vivek Goyal wrote:
> >
> >
> > o After a crash we should wait for NMI IPI event and not for external NMI
> > or NMI watchdog tick.
>
> The two patches don't apply anymore after Don's big NMI rework.
> Can you forward port and retest/resend please?
I have all this stuff queued up against your tree - I'll send it over.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-05-16 18:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-05-15 17:48 [PATCH] Kdump i386 nmi event notification fix Vivek Goyal
2006-05-16 18:15 ` Andi Kleen
2006-05-16 18:35 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®