* [patch 39/50] genirq: ARM: Convert omap1 to generic irq handling
@ 2006-05-17 0:18 Ingo Molnar
2006-05-17 2:55 ` Daniel Walker
0 siblings, 1 reply; 3+ messages in thread
From: Ingo Molnar @ 2006-05-17 0:18 UTC (permalink / raw)
To: linux-kernel
Cc: Thomas Gleixner, Benjamin Herrenschmidt, Russell King,
Andrew Morton, Christoph Hellwig, linux-arm-kernel
From: Thomas Gleixner <tglx@linutronix.de>
Fixup the conversion to generic irq subsystem.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/arm/mach-omap1/board-osk.c | 2 +-
arch/arm/mach-omap1/serial.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
Index: linux-genirq.q/arch/arm/mach-omap1/board-osk.c
===================================================================
--- linux-genirq.q.orig/arch/arm/mach-omap1/board-osk.c
+++ linux-genirq.q/arch/arm/mach-omap1/board-osk.c
@@ -29,7 +29,7 @@
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/platform_device.h>
-#include <linux/interrupt.h>
+#include <linux/irq.h>
#include <linux/mtd/mtd.h>
#include <linux/mtd/partitions.h>
Index: linux-genirq.q/arch/arm/mach-omap1/serial.c
===================================================================
--- linux-genirq.q.orig/arch/arm/mach-omap1/serial.c
+++ linux-genirq.q/arch/arm/mach-omap1/serial.c
@@ -12,6 +12,7 @@
#include <linux/module.h>
#include <linux/kernel.h>
#include <linux/init.h>
+#include <linux/irq.h>
#include <linux/delay.h>
#include <linux/serial.h>
#include <linux/tty.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 39/50] genirq: ARM: Convert omap1 to generic irq handling
2006-05-17 0:18 [patch 39/50] genirq: ARM: Convert omap1 to generic irq handling Ingo Molnar
@ 2006-05-17 2:55 ` Daniel Walker
2006-05-17 8:36 ` Ingo Molnar
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Walker @ 2006-05-17 2:55 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Thomas Gleixner, Benjamin Herrenschmidt,
Russell King, Andrew Morton, Christoph Hellwig, linux-arm-kernel
The set_wake member in irq_chip structure must have changed ..
In -v3 it's
int (*set_wake)(unsigned int irq, int on);
and in arch/arm/mach-omap1/irq.c that member gets set to
static int omap_wake_irq(unsigned int irq, unsigned int enable)
this is from 2.6.17-rc4 so it's likely in some level of flux either in
the generic irq patch or the omap tree ..
Daniel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 39/50] genirq: ARM: Convert omap1 to generic irq handling
2006-05-17 2:55 ` Daniel Walker
@ 2006-05-17 8:36 ` Ingo Molnar
0 siblings, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2006-05-17 8:36 UTC (permalink / raw)
To: Daniel Walker
Cc: linux-kernel, Thomas Gleixner, Benjamin Herrenschmidt,
Russell King, Andrew Morton, Christoph Hellwig, linux-arm-kernel
* Daniel Walker <dwalker@mvista.com> wrote:
> The set_wake member in irq_chip structure must have changed ..
>
> In -v3 it's
>
> int (*set_wake)(unsigned int irq, int on);
>
> and in arch/arm/mach-omap1/irq.c that member gets set to
>
> static int omap_wake_irq(unsigned int irq, unsigned int enable)
>
> this is from 2.6.17-rc4 so it's likely in some level of flux either in
> the generic irq patch or the omap tree ..
indeed - it's flux from -v4 cleanups. I have changed it back to
'unsigned int on'.
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-05-17 8:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-05-17 0:18 [patch 39/50] genirq: ARM: Convert omap1 to generic irq handling Ingo Molnar
2006-05-17 2:55 ` Daniel Walker
2006-05-17 8:36 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®