* [patch] initialize variables to reduce i386 warnings
@ 2006-05-20 23:19 Ameer Armaly
2006-05-20 23:27 ` Michael Buesch
2006-05-21 0:02 ` Chris Wedgwood
0 siblings, 2 replies; 3+ messages in thread
From: Ameer Armaly @ 2006-05-20 23:19 UTC (permalink / raw)
To: linux-kernel
Initialized cpu_freq in arch/i386/kernel/cpu/transmeta.c to suppress warning.
diff --git a/arch/i386/kernel/cpu/transmeta.c b/arch/i386/kernel/cpu/transmeta.c
index 7214c9b..0737890 100644
--- a/arch/i386/kernel/cpu/transmeta.c
+++ b/arch/i386/kernel/cpu/transmeta.c
@@ -9,7 +9,7 @@ static void __init init_transmeta(struct
{
unsigned int cap_mask, uk, max, dummy;
unsigned int cms_rev1, cms_rev2;
- unsigned int cpu_rev, cpu_freq, cpu_flags, new_cpu_rev;
+ unsigned int cpu_rev, cpu_freq = 0, cpu_flags, new_cpu_rev;
char cpu_info[65];
get_model_name(c); /* Same as AMD/Cyrix */
!-------------------------------------------------------------flip-
More variable initializations to get rid of warnings.
diff --git a/arch/i386/kernel/apm.c b/arch/i386/kernel/apm.c
index df0e174..39838a1 100644
--- a/arch/i386/kernel/apm.c
+++ b/arch/i386/kernel/apm.c
@@ -1063,7 +1063,7 @@ #if defined(CONFIG_APM_DISPLAY_BLANK) &&
static int apm_console_blank(int blank)
{
- int error, i;
+ int error = 0, i;
u_short state;
static const u_short dev[3] = { 0x100, 0x1FF, 0x101 };
diff --git a/arch/i386/kernel/efi.c b/arch/i386/kernel/efi.c
index 9202b67..3a7e485 100644
--- a/arch/i386/kernel/efi.c
+++ b/arch/i386/kernel/efi.c
@@ -270,8 +270,8 @@ void efi_memmap_walk(efi_freemem_callbac
{
int prev_valid = 0;
struct range {
- unsigned long start;
- unsigned long end;
+ unsigned long start = 0;
+ unsigned long end = 0;
} prev, curr;
efi_memory_desc_t *md;
unsigned long start, end;
!-------------------------------------------------------------flip-
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] initialize variables to reduce i386 warnings
2006-05-20 23:19 [patch] initialize variables to reduce i386 warnings Ameer Armaly
@ 2006-05-20 23:27 ` Michael Buesch
2006-05-21 0:02 ` Chris Wedgwood
1 sibling, 0 replies; 3+ messages in thread
From: Michael Buesch @ 2006-05-20 23:27 UTC (permalink / raw)
To: Ameer Armaly; +Cc: linux-kernel
On Sunday 21 May 2006 01:19, you wrote:
> Initialized cpu_freq in arch/i386/kernel/cpu/transmeta.c to suppress warning.
> index 9202b67..3a7e485 100644
> --- a/arch/i386/kernel/efi.c
> +++ b/arch/i386/kernel/efi.c
> @@ -270,8 +270,8 @@ void efi_memmap_walk(efi_freemem_callbac
> {
> int prev_valid = 0;
> struct range {
> - unsigned long start;
> - unsigned long end;
> + unsigned long start = 0;
> + unsigned long end = 0;
> } prev, curr;
Did you actually try to compile the stuff before submission?
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] initialize variables to reduce i386 warnings
2006-05-20 23:19 [patch] initialize variables to reduce i386 warnings Ameer Armaly
2006-05-20 23:27 ` Michael Buesch
@ 2006-05-21 0:02 ` Chris Wedgwood
1 sibling, 0 replies; 3+ messages in thread
From: Chris Wedgwood @ 2006-05-21 0:02 UTC (permalink / raw)
To: Ameer Armaly; +Cc: linux-kernel
On Sat, May 20, 2006 at 07:19:48PM -0400, Ameer Armaly wrote:
> Initialized cpu_freq in arch/i386/kernel/cpu/transmeta.c to suppress
> warning.
Urgh.
Doing this just to silence gcc is wrong. I know we've done this at
times in the past and that's still not right (I would argue those
should be reverted even).
> struct range {
> - unsigned long start;
> - unsigned long end;
> + unsigned long start = 0;
> + unsigned long end = 0;
?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-05-21 0:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-05-20 23:19 [patch] initialize variables to reduce i386 warnings Ameer Armaly
2006-05-20 23:27 ` Michael Buesch
2006-05-21 0:02 ` Chris Wedgwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®