[patch] initialize variables in fs/isofs/namei.c

[patch] initialize variables in fs/isofs/namei.c

[Ameer Armaly]

This patch removes un-initialized variable warnings for block and offset in namei.c, which are later initialized through a call to isofs_find_entry().

diff --git a/fs/isofs/namei.c b/fs/isofs/namei.c
index e7ba0c3..e0d6531 100644
--- a/fs/isofs/namei.c
+++ b/fs/isofs/namei.c
@@ -159,7 +159,7 @@ #endif
  struct dentry *isofs_lookup(struct inode * dir, struct dentry * dentry, struct nameidata *nd)
  {
  	int found;
-	unsigned long block, offset;
+	unsigned long block = 0, offset = 0;
  	struct inode *inode;
  	struct page *page;

Re: [patch] initialize variables in fs/isofs/namei.c

[Dave Jones]

On Sun, May 21, 2006 at 03:02:34PM -0400, Ameer Armaly wrote:
 > This patch removes un-initialized variable warnings for block and offset in 
 > namei.c, which are later initialized through a call to isofs_find_entry().

Which indicates the problem lies with gcc, just like with the other patches
'fixing' these warnings.

The warning is bogus.

		Dave

-- 
http://www.codemonkey.org.uk

Re: [patch] initialize variables in fs/isofs/namei.c

[Ameer Armaly]

On Sun, 21 May 2006, Dave Jones wrote:

> On Sun, May 21, 2006 at 03:02:34PM -0400, Ameer Armaly wrote:
> > This patch removes un-initialized variable warnings for block and offset in
> > namei.c, which are later initialized through a call to isofs_find_entry().
>
> Which indicates the problem lies with gcc, just like with the other patches
> 'fixing' these warnings.
>
I agree.  The compiler should be smart enough to at least consider the 
possibility of initializing through pointers.
> The warning is bogus.
>
It is, but at the same it's clutter; in my opinion, readability is not 
impacted by explicitly initializing variables that get initialized through 
a pointer, and we reduce annoying make output.
  > 		Dave
>
> -- 
> http://www.codemonkey.org.uk
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>