mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 2/3][resend] moxa: remove pointless check of 'tty' argument vs NULL
@ 2006-05-22 22:09 Jesper Juhl
  0 siblings, 0 replies; only message in thread
From: Jesper Juhl @ 2006-05-22 22:09 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Alan Cox, Martin Mares, Alexey Dobriyan, Moxa Technologies,
	linux-kernel, Jesper Juhl

(This patch was originaly send on 15/05-2006 - this is a resend.
 Patch still applies cleanly to 2.6.17-rc4-mm3)


Remove pointless check of 'tty' argument vs NULL from moxa driver.
(applies on top of patch 1/3)

(Discussion about the patch when it was initially posted resulted in 
agreement that this is the right thing to do.)


Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---

 drivers/char/mxser.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.17-rc4-mm1/drivers/char/mxser.c.1	2006-05-15 22:33:49.000000000 +0200
+++ linux-2.6.17-rc4-mm1/drivers/char/mxser.c	2006-05-15 22:34:38.000000000 +0200
@@ -1081,7 +1081,7 @@ static int mxser_write(struct tty_struct
 	struct mxser_struct *info = tty->driver_data;
 	unsigned long flags;
 
-	if (!tty || !info->xmit_buf)
+	if (!info->xmit_buf)
 		return (0);
 
 	while (1) {
@@ -1117,7 +1117,7 @@ static void mxser_put_char(struct tty_st
 	struct mxser_struct *info = tty->driver_data;
 	unsigned long flags;
 
-	if (!tty || !info->xmit_buf)
+	if (!info->xmit_buf)
 		return;
 
 	if (info->xmit_cnt >= SERIAL_XMIT_SIZE - 1)




^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-05-22 22:08 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-05-22 22:09 [PATCH 2/3][resend] moxa: remove pointless check of 'tty' argument vs NULL Jesper Juhl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®