* Re: [PATCH 2/3] pci: bcm43xx kill pci_find_device [not found] <20060525003040.A91E0C7BDC@atrey.karlin.mff.cuni.cz> @ 2006-05-25 0:45 ` Jeff Garzik 2006-05-25 21:55 ` Michael Buesch 0 siblings, 1 reply; 2+ messages in thread From: Jeff Garzik @ 2006-05-25 0:45 UTC (permalink / raw) To: Jiri Slaby; +Cc: Greg KH, Linux Kernel Mailing List, linux-pci, Netdev List Jiri Slaby wrote: > bcm43xx kill pci_find_device > > Change pci_find_device to safer pci_get_device. > > Signed-off-by: Jiri Slaby <jirislaby@gmail.com> > > --- > commit 75664d3c6fe1d8d00b87e42cc001cb5d90613dae > tree ebcec31955a991f1661197c7e8bcdd682e030681 > parent 431ef31d431939bc9370f952d9510ab9e5b0ad47 > author Jiri Slaby <ku@bellona.localdomain> Thu, 25 May 2006 02:04:38 +0159 > committer Jiri Slaby <ku@bellona.localdomain> Thu, 25 May 2006 02:04:38 +0159 > > drivers/net/wireless/bcm43xx/bcm43xx_main.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/wireless/bcm43xx/bcm43xx_main.c b/drivers/net/wireless/bcm43xx/bcm43xx_main.c > index b488f77..f770f59 100644 > --- a/drivers/net/wireless/bcm43xx/bcm43xx_main.c > +++ b/drivers/net/wireless/bcm43xx/bcm43xx_main.c > @@ -2142,9 +2142,10 @@ #ifdef CONFIG_BCM947XX > if (bcm->pci_dev->bus->number == 0) { > struct pci_dev *d = NULL; > /* FIXME: we will probably need more device IDs here... */ > - d = pci_find_device(PCI_VENDOR_ID_BROADCOM, 0x4324, NULL); > + d = pci_get_device(PCI_VENDOR_ID_BROADCOM, 0x4324, NULL); > if (d != NULL) { > bcm->irq = d->irq; > + pci_dev_put(d); Given the FIXME, if you are going to touch this area, it seems logical to add a PCI device match table. Jeff ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2/3] pci: bcm43xx kill pci_find_device 2006-05-25 0:45 ` [PATCH 2/3] pci: bcm43xx kill pci_find_device Jeff Garzik @ 2006-05-25 21:55 ` Michael Buesch 0 siblings, 0 replies; 2+ messages in thread From: Michael Buesch @ 2006-05-25 21:55 UTC (permalink / raw) To: Jiri Slaby Cc: Jeff Garzik, Greg KH, Linux Kernel Mailing List, linux-pci, Netdev List On Thursday 25 May 2006 02:45, you wrote: > Jiri Slaby wrote: > > bcm43xx kill pci_find_device > > > > Change pci_find_device to safer pci_get_device. > > > > Signed-off-by: Jiri Slaby <jirislaby@gmail.com> > > > > --- > > commit 75664d3c6fe1d8d00b87e42cc001cb5d90613dae > > tree ebcec31955a991f1661197c7e8bcdd682e030681 > > parent 431ef31d431939bc9370f952d9510ab9e5b0ad47 > > author Jiri Slaby <ku@bellona.localdomain> Thu, 25 May 2006 02:04:38 +0159 > > committer Jiri Slaby <ku@bellona.localdomain> Thu, 25 May 2006 02:04:38 +0159 > > > > drivers/net/wireless/bcm43xx/bcm43xx_main.c | 3 ++- > > 1 files changed, 2 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/net/wireless/bcm43xx/bcm43xx_main.c b/drivers/net/wireless/bcm43xx/bcm43xx_main.c > > index b488f77..f770f59 100644 > > --- a/drivers/net/wireless/bcm43xx/bcm43xx_main.c > > +++ b/drivers/net/wireless/bcm43xx/bcm43xx_main.c > > @@ -2142,9 +2142,10 @@ #ifdef CONFIG_BCM947XX > > if (bcm->pci_dev->bus->number == 0) { > > struct pci_dev *d = NULL; > > /* FIXME: we will probably need more device IDs here... */ > > - d = pci_find_device(PCI_VENDOR_ID_BROADCOM, 0x4324, NULL); > > + d = pci_get_device(PCI_VENDOR_ID_BROADCOM, 0x4324, NULL); > > if (d != NULL) { > > bcm->irq = d->irq; > > + pci_dev_put(d); > > Given the FIXME, if you are going to touch this area, it seems logical > to add a PCI device match table. Yes, you may want to discuss that with the openwrt people, as this code is only openwrt related. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-05-25 21:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20060525003040.A91E0C7BDC@atrey.karlin.mff.cuni.cz>
2006-05-25 0:45 ` [PATCH 2/3] pci: bcm43xx kill pci_find_device Jeff Garzik
2006-05-25 21:55 ` Michael Buesch
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
Powered by JetHome