From: Pavel Machek <pavel@suse.cz>
To: David Brownell <david-b@pacbell.net>,
rpurdie@rpsys.net, lenz@cs.wisc.edu,
kernel list <linux-kernel@vger.kernel.org>,
patches@arm.linux.org.uk
Cc: linux-usb-devel@lists.sourceforge.net,
Oliver Neukum <oliver@neukum.org>,
David Liontooth <liontooth@cogweb.net>
Subject: [PATCH] limit power budget on spitz
Date: Thu, 8 Jun 2006 10:34:12 +0200 [thread overview]
Message-ID: <20060608083412.GJ3688@elf.ucw.cz> (raw)
In-Reply-To: <200606050732.53496.david-b@pacbell.net>
This limits power budget on spitz to 250mA. I'm not sure if it is the
right value, but it is certainly better than default 500mA, and
prevents nasty failure mode with zd1201.
Signed-off-by: Pavel Machek <pavel@suse.cz>
PATCH FOLLOWS
KernelVersion: 2.6.17-rc6-git
diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci-pxa27x.c
index acde886..1d8b58c 100644
--- a/drivers/usb/host/ohci-pxa27x.c
+++ b/drivers/usb/host/ohci-pxa27x.c
@@ -185,6 +185,13 @@ int usb_hcd_pxa27x_probe (const struct h
/* Select Power Management Mode */
pxa27x_ohci_select_pmm(inf->port_mode);
+ if (machine_is_spitz()) {
+ /* Warning, not coming from any official docs. But
+ * spitz is unable to properly power wireless card
+ * claiming 500mA -- usb interface work but wireless
+ * does not. */
+ hcd->power_budget = 250;
+ }
ohci_hcd_init(hcd_to_ohci(hcd));
retval = usb_add_hcd(hcd, pdev->resource[1].start, SA_INTERRUPT);
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2006-06-08 8:35 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-01 9:18 USB devices fail unnecessarily on unpowered hubs David Liontooth
2006-05-30 20:01 ` Pavel Machek
2006-06-03 9:29 ` Oliver Neukum
2006-06-05 14:32 ` [linux-usb-devel] " David Brownell
2006-06-06 7:43 ` Oliver Neukum
2006-06-08 7:01 ` Pavel Machek
2006-06-08 8:34 ` Pavel Machek [this message]
2006-06-08 8:50 ` [PATCH] limit power budget on spitz Richard Purdie
2006-06-08 9:02 ` Pavel Machek
2006-06-08 9:22 ` Richard Purdie
2006-06-08 17:09 ` Russell King
2006-06-08 18:26 ` David Brownell
2006-06-08 20:06 ` Richard Purdie
2006-06-08 20:38 ` [linux-usb-devel] " David Brownell
2006-06-08 21:22 ` Richard Purdie
2006-06-08 21:40 ` David Brownell
2006-06-08 21:49 ` Richard Purdie
2006-06-08 23:44 ` David Brownell
2006-06-09 1:25 ` Nicolas Pitre
2006-06-09 2:03 ` David Brownell
2006-06-09 2:34 ` Nicolas Pitre
2006-06-01 10:01 ` USB devices fail unnecessarily on unpowered hubs Andrew Morton
2006-06-01 11:42 ` Daniel Drake
2006-06-01 14:58 ` Alan Stern
2006-06-01 15:09 ` linux-os (Dick Johnson)
2006-06-01 15:23 ` Lennart Sorensen
2006-06-01 21:39 ` Dagfinn Ilmari Mannsåker
2006-06-01 15:53 ` Oliver Neukum
2006-06-01 17:24 ` linux-os (Dick Johnson)
2006-06-01 16:57 ` Alan Stern
2006-06-01 16:43 ` [linux-usb-devel] " Greg KH
2006-06-02 0:03 ` David Liontooth
2006-06-02 1:53 ` [linux-usb-devel] " David Brownell
2006-06-02 7:12 ` Oliver Neukum
2006-06-02 15:11 ` Alan Stern
2006-06-02 19:49 ` David Liontooth
2006-06-01 16:59 ` Andrew Morton
2006-06-01 17:08 ` Alan Stern
2006-06-01 17:34 ` Mark Lord
2006-06-01 17:47 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060608083412.GJ3688@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=david-b@pacbell.net \
--cc=lenz@cs.wisc.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=liontooth@cogweb.net \
--cc=oliver@neukum.org \
--cc=patches@arm.linux.org.uk \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome