mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Oeser <ioe-lkml@rameria.de>
To: Wu Fengguang <wfg@mail.ustc.edu.cn>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, Michael Tokarev <mjt@tls.msk.ru>,
	Jens Axboe <axboe@suse.de>
Subject: Re: [PATCH 4/5] readahead: backoff on I/O error
Date: Sat, 10 Jun 2006 20:33:45 +0200	[thread overview]
Message-ID: <200606102033.46844.ioe-lkml@rameria.de> (raw)
In-Reply-To: <349840680.03819@ustc.edu.cn>

Hi Fengguang,

On Friday, 9. June 2006 10:08, Wu Fengguang wrote:
> Backoff readahead size exponentially on I/O error.
 
> With this patch, retries are expected to be reduced from, say, 256, to 5.
 
1. Would you mind to push this patch to -stable?

Reason: If killing a drive was hit in the field, this should be critical 
	enough.

2. Could you disable (at least optionally) read ahead complety 
  on the first IO error?

Reason: In a data recovery situation (hitting EIO quite often, 
	but not really sequentially) readahead is counter productive.
	E.g. trying to save an old CD with the cdparanoia software.


Regards

Ingo Oeser

  reply	other threads:[~2006-06-10 18:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20060609080801.741901069@localhost.localdomain>
2006-06-09  8:08 ` [PATCH 0/5] Adaptive readahead updates 2 Wu Fengguang
     [not found] ` <20060609081119.231751179@localhost.localdomain>
2006-06-09  8:08   ` [PATCH 1/5] readahead: no RA_FLAG_EOF on single page file Wu Fengguang
     [not found] ` <20060609081120.054527393@localhost.localdomain>
2006-06-09  8:08   ` [PATCH 3/5] readahead: call scheme - no fastcall for readahead_cache_hit() Wu Fengguang
     [not found] ` <20060609081120.531013274@localhost.localdomain>
2006-06-09  8:08   ` [PATCH 4/5] readahead: backoff on I/O error Wu Fengguang
2006-06-10 18:33     ` Ingo Oeser [this message]
2006-06-10 19:48       ` Michael Tokarev
     [not found]         ` <20060612011245.GA5214@mail.ustc.edu.cn>
2006-06-12  1:12           ` Wu Fengguang
2006-06-12  3:43             ` Andrew Morton
2006-06-12 11:06             ` Michael Tokarev
2006-06-17  6:38               ` Michael Tokarev
2006-06-17  7:00                 ` Michael Tokarev
     [not found] ` <20060609081121.002572642@localhost.localdomain>
2006-06-09  8:08   ` [PATCH 5/5] readahead: remove size limit on read_ahead_kb Wu Fengguang
2006-06-11  5:34 [PATCH 4/5] readahead: backoff on I/O error Just Marc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200606102033.46844.ioe-lkml@rameria.de \
    --to=ioe-lkml@rameria.de \
    --cc=akpm@osdl.org \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjt@tls.msk.ru \
    --cc=wfg@mail.ustc.edu.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®