From: Andrew Morton <akpm@osdl.org>
To: Wu Fengguang <wfg@mail.ustc.edu.cn>
Cc: mjt@tls.msk.ru, ioe-lkml@rameria.de,
linux-kernel@vger.kernel.org, axboe@suse.de
Subject: Re: [PATCH 4/5] readahead: backoff on I/O error
Date: Sun, 11 Jun 2006 20:43:18 -0700 [thread overview]
Message-ID: <20060611204318.ebc42608.akpm@osdl.org> (raw)
In-Reply-To: <350074764.23563@ustc.edu.cn>
On Mon, 12 Jun 2006 09:12:45 +0800
Wu Fengguang <wfg@mail.ustc.edu.cn> wrote:
> Andrew:
> I was a bit afraid about that because I have no CDROM to try it out.
> But since Michael has tested it OK, it should be OK for the stable kernel.
hm. It's a problem, but not a terribly huge one.
It's nice to print the filename, but we shouldn't use d_iname because long
filenames aren't stored there. And if the file was unlinked after open
then I don't think we'll oops, but the filename isn't very meaningful.
So...
--- devel/mm/filemap.c~readahead-backoff-on-i-o-error-tweaks 2006-06-11 20:40:52.000000000 -0700
+++ devel-akpm/mm/filemap.c 2006-06-11 20:41:05.000000000 -0700
@@ -804,8 +804,7 @@ static void shrink_readahead_size_eio(st
return;
ra->ra_pages /= 4;
- printk(KERN_WARNING "Retracting readahead size of %s to %luK\n",
- filp->f_dentry->d_iname,
+ printk(KERN_WARNING "Reducing readahead size to %luK\n",
ra->ra_pages << (PAGE_CACHE_SHIFT - 10));
}
_
next prev parent reply other threads:[~2006-06-12 3:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060609080801.741901069@localhost.localdomain>
2006-06-09 8:08 ` [PATCH 0/5] Adaptive readahead updates 2 Wu Fengguang
[not found] ` <20060609081119.231751179@localhost.localdomain>
2006-06-09 8:08 ` [PATCH 1/5] readahead: no RA_FLAG_EOF on single page file Wu Fengguang
[not found] ` <20060609081120.054527393@localhost.localdomain>
2006-06-09 8:08 ` [PATCH 3/5] readahead: call scheme - no fastcall for readahead_cache_hit() Wu Fengguang
[not found] ` <20060609081120.531013274@localhost.localdomain>
2006-06-09 8:08 ` [PATCH 4/5] readahead: backoff on I/O error Wu Fengguang
2006-06-10 18:33 ` Ingo Oeser
2006-06-10 19:48 ` Michael Tokarev
[not found] ` <20060612011245.GA5214@mail.ustc.edu.cn>
2006-06-12 1:12 ` Wu Fengguang
2006-06-12 3:43 ` Andrew Morton [this message]
2006-06-12 11:06 ` Michael Tokarev
2006-06-17 6:38 ` Michael Tokarev
2006-06-17 7:00 ` Michael Tokarev
[not found] ` <20060609081121.002572642@localhost.localdomain>
2006-06-09 8:08 ` [PATCH 5/5] readahead: remove size limit on read_ahead_kb Wu Fengguang
2006-06-11 5:34 [PATCH 4/5] readahead: backoff on I/O error Just Marc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060611204318.ebc42608.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=ioe-lkml@rameria.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mjt@tls.msk.ru \
--cc=wfg@mail.ustc.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome