mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] s390: move var declarations behind ifdef
@ 2006-06-14 12:07 Serge E. Hallyn
  2006-06-23  9:59 ` Frank Pavlic
  0 siblings, 1 reply; 2+ messages in thread
From: Serge E. Hallyn @ 2006-06-14 12:07 UTC (permalink / raw)
  To: fpavlic, linux390, lkml

Two variables in drivers/s390/net/qeth_main.c:qeth_send_packet()
are only used if CONFIG_QETH_PERF_STATS.  Move their definition
under the same ifdef to remove compiler warning.

Signed-off-by: Serge Hallyn <serue@us.ibm.com>

---

 drivers/s390/net/qeth_main.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

74bcd2e9461534ccd39ec84455b0b2c07c7f24a5
diff --git a/drivers/s390/net/qeth_main.c b/drivers/s390/net/qeth_main.c
index 9e671a4..8f8c0f4 100644
--- a/drivers/s390/net/qeth_main.c
+++ b/drivers/s390/net/qeth_main.c
@@ -4416,8 +4416,10 @@ qeth_send_packet(struct qeth_card *card,
 	enum qeth_large_send_types large_send = QETH_LARGE_SEND_NO;
 	struct qeth_eddp_context *ctx = NULL;
 	int tx_bytes = skb->len;
+#ifdef CONFIG_QETH_PERF_STATS
 	unsigned short nr_frags = skb_shinfo(skb)->nr_frags;
 	unsigned short tso_size = skb_shinfo(skb)->tso_size;
+#endif
 	int rc;
 
 	QETH_DBF_TEXT(trace, 6, "sendpkt");
-- 
1.1.6

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] s390: move var declarations behind ifdef
  2006-06-14 12:07 [PATCH] s390: move var declarations behind ifdef Serge E. Hallyn
@ 2006-06-23  9:59 ` Frank Pavlic
  0 siblings, 0 replies; 2+ messages in thread
From: Frank Pavlic @ 2006-06-23  9:59 UTC (permalink / raw)
  To: Serge E. Hallyn; +Cc: linux390, lkml

On Wed, 14 Jun 2006 07:07:33 -0500
"Serge E. Hallyn" <serue@us.ibm.com> wrote:

> Two variables in drivers/s390/net/qeth_main.c:qeth_send_packet()
> are only used if CONFIG_QETH_PERF_STATS.  Move their definition
> under the same ifdef to remove compiler warning.
> 
> Signed-off-by: Serge Hallyn <serue@us.ibm.com>
> 
> ---
> 
>  drivers/s390/net/qeth_main.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> 74bcd2e9461534ccd39ec84455b0b2c07c7f24a5
> diff --git a/drivers/s390/net/qeth_main.c b/drivers/s390/net/qeth_main.c
> index 9e671a4..8f8c0f4 100644
> --- a/drivers/s390/net/qeth_main.c
> +++ b/drivers/s390/net/qeth_main.c
> @@ -4416,8 +4416,10 @@ qeth_send_packet(struct qeth_card *card,
>  	enum qeth_large_send_types large_send = QETH_LARGE_SEND_NO;
>  	struct qeth_eddp_context *ctx = NULL;
>  	int tx_bytes = skb->len;
> +#ifdef CONFIG_QETH_PERF_STATS
>  	unsigned short nr_frags = skb_shinfo(skb)->nr_frags;
>  	unsigned short tso_size = skb_shinfo(skb)->tso_size;
> +#endif
>  	int rc;
>  
>  	QETH_DBF_TEXT(trace, 6, "sendpkt");

Hi Serge,

thanks for the patch...Applied ...
I will send it out with the next patch series .

Frank

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-06-23  9:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-06-14 12:07 [PATCH] s390: move var declarations behind ifdef Serge E. Hallyn
2006-06-23  9:59 ` Frank Pavlic

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®