mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
To: alessandro.zummo@towertech.it
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] RTC: add rtc-ds1553 and rtc-ds1742 driver
Date: Sun, 25 Jun 2006 23:38:08 +0900 (JST)	[thread overview]
Message-ID: <20060625.233808.59465787.anemo@mba.ocn.ne.jp> (raw)
In-Reply-To: <20060625115525.098f53a5@inspiron>

On Sun, 25 Jun 2006 11:55:25 +0200, Alessandro Zummo <alessandro.zummo@towertech.it> wrote:
> > No, it is intentional.  If irq is not available, I want to fall back
> > into emulation in rtc-dev.c.
> 
>  maybe you can add a comment explaining this choice

Indeed.  Here it is.


Subject: RTC: Add a comment for ENOIOCTLCMD in ds1553_rtc_ioctl.

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>

--- linux-2.6.17-mm2/drivers/rtc/rtc-ds1553.c	2006-06-25 23:28:24.387004000 +0900
+++ linux/drivers/rtc/rtc-ds1553.c	2006-06-25 23:31:00.156324096 +0900
@@ -226,7 +226,7 @@
 	struct rtc_plat_data *pdata = platform_get_drvdata(pdev);
 
 	if (pdata->irq < 0)
-		return -ENOIOCTLCMD;
+		return -ENOIOCTLCMD; /* fall back into rtc-dev's emulation */
 	switch (cmd) {
 	case RTC_AIE_OFF:
 		pdata->irqen &= ~RTC_AF;

      reply	other threads:[~2006-06-25 14:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-22 15:19 Atsushi Nemoto
2006-06-22 22:16 ` Alessandro Zummo
2006-06-23  9:28   ` Atsushi Nemoto
2006-06-25  9:55     ` Alessandro Zummo
2006-06-25 14:38       ` Atsushi Nemoto [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060625.233808.59465787.anemo@mba.ocn.ne.jp \
    --to=anemo@mba.ocn.ne.jp \
    --cc=akpm@osdl.org \
    --cc=alessandro.zummo@towertech.it \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®