From: Alessandro Zummo <alessandro.zummo@towertech.it>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] RTC: add rtc-ds1553 and rtc-ds1742 driver
Date: Sun, 25 Jun 2006 11:55:25 +0200 [thread overview]
Message-ID: <20060625115525.098f53a5@inspiron> (raw)
In-Reply-To: <20060623.182828.92343173.nemoto@toshiba-tops.co.jp>
On Fri, 23 Jun 2006 18:28:28 +0900 (JST)
Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> > > +static int ds1553_rtc_ioctl(struct device *dev, unsigned int cmd,
> > > + unsigned long arg)
> > > +{
> > > + struct platform_device *pdev = to_platform_device(dev);
> > > + struct rtc_plat_data *pdata = platform_get_drvdata(pdev);
> > > +
> > > + if (pdata->irq < 0)
> > > + return -ENOIOCTLCMD;
> >
> > inappropriate -Exxx . maybe -ENODEV?.
>
> No, it is intentional. If irq is not available, I want to fall back
> into emulation in rtc-dev.c.
maybe you can add a comment explaining this choice
--
Best regards,
Alessandro Zummo,
Tower Technologies - Turin, Italy
http://www.towertech.it
next prev parent reply other threads:[~2006-06-25 9:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-22 15:19 Atsushi Nemoto
2006-06-22 22:16 ` Alessandro Zummo
2006-06-23 9:28 ` Atsushi Nemoto
2006-06-25 9:55 ` Alessandro Zummo [this message]
2006-06-25 14:38 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060625115525.098f53a5@inspiron \
--to=alessandro.zummo@towertech.it \
--cc=akpm@osdl.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®