mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Al Boldi <a1426z@gawab.com>
To: Peter Williams <pwil3058@bigpond.net.au>
Cc: linux-kernel@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
	Jan Engelhardt <jengelh@linux01.gwdg.de>,
	Con Kolivas <kernel@kolivas.org>
Subject: Re: Incorrect CPU process accounting using CONFIG_HZ=100
Date: Wed, 28 Jun 2006 23:06:14 +0300	[thread overview]
Message-ID: <200606282306.14498.a1426z@gawab.com> (raw)
In-Reply-To: <44A1C4D4.3080805@bigpond.net.au>

Peter Williams wrote:
> Con Kolivas wrote:
> > On Tuesday 27 June 2006 22:32, Al Boldi wrote:
> >> Pavel Machek wrote:
> >>> On Thu 2006-06-22 20:36:39, Al Boldi wrote:
> >>>> Jan Engelhardt wrote:
> >>>>>> Setting CONFIG_HZ=100 results in incorrect CPU process accounting.
> >>>>>>
> >>>>>> This can be seen running top d.1, that shows top, itself, consuming
> >>>>>> 0ms CPUtime.
> >>>>>>
> >>>>>> Will this bug have consequences for sched.c?
> >>>>>
> >>>>> Works for me, somewhat.
> >>>>> TIME+ says 0:00.02 after 70 secs. (Ergo: top is not expensive on
> >>>>> this CPU.)
> >>>>
> >>>> That's what I thought for a long time.  But at closer inspection, top
> >>>> d.1 slows down other apps by about the same amount of time at 1000Hz
> >>>> and 100Hz, only at 1000Hz it is accounted for whereas at 100Hz it is
> >>>> not.
> >>>
> >>> It is not a bug... it is design decision. If you eat "too little" cpu
> >>> time, you'll be accouted 0 msec. That's what happens at 100Hz...
> >>
> >> Bummer!
> >>
> > The actual problem is that tasks
> > only get charged if they happen to be running at the precise moment the
> > tick fires. Now you could increase the accuracy of this timekeeping but
> > it is expensive and this is exactly the sort of thing that we're saving
> > cpu resources on by running at 100HZ (one of many).
>
> It could be (partly) done fairly cheaply in nanoseconds if sched_clock()
> was reliable enough (but comments on this mail list indicate that it
> currently isn't) as it is already called in all the right places for
> getting the total cpu time used (so just a subtraction, addition and
> assignment).  The reason that I say partly is that splitting the time
> into "system" and "user" would be a more complex problem.

If I am reading this correctly, then the kernel is accounting process times 
twice:
	1. for external proc monitoring, using a probed approach
	2. for scheduling, using an inlined approach

Wouldn't merging the two approaches be in the interest of conserving cpu 
resources, while at the same time reflecting an accurate view of cpu 
utilization?

Thanks!

--
Al


  reply	other threads:[~2006-06-28 20:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-21 14:16 Al Boldi
2006-06-22  5:46 ` Jan Engelhardt
2006-06-22 17:36   ` Al Boldi
2006-06-26 16:02     ` Pavel Machek
2006-06-27 12:32       ` Al Boldi
2006-06-27 13:02         ` Con Kolivas
2006-06-27 23:52           ` Peter Williams
2006-06-28 20:06             ` Al Boldi [this message]
2006-06-28 23:23               ` Peter Williams
2006-06-28 23:46                 ` Con Kolivas
2006-06-29  0:25                   ` Peter Williams
2006-06-29  1:10                     ` Con Kolivas
2006-06-29  7:29                     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200606282306.14498.a1426z@gawab.com \
    --to=a1426z@gawab.com \
    --cc=jengelh@linux01.gwdg.de \
    --cc=kernel@kolivas.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=pwil3058@bigpond.net.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®