From: Nathan Scott <nathans@sgi.com>
To: Erik Frederiksen <erik_frederiksen@pmc-sierra.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: IS_ERR Threshold Value
Date: Thu, 29 Jun 2006 09:23:05 +1000 [thread overview]
Message-ID: <20060629092305.D1344246@wobbly.melbourne.sgi.com> (raw)
In-Reply-To: <1151536413.3903.1135.camel@girvin.pmc-sierra.bc.ca>; from erik_frederiksen@pmc-sierra.com on Wed, Jun 28, 2006 at 05:13:33PM -0600
On Wed, Jun 28, 2006 at 05:13:33PM -0600, Erik Frederiksen wrote:
> On Wed, 2006-06-28 at 16:41, Nathan Scott wrote:
> > Hmm, I'm not sure I understand the XFS side of your report here - on
> ...
> XFS has acted correctly. The only reason I bring it up is this is how
> the bug was brought to my attention.
Ah, OK. When you said this...
| it caused an alignment exception in the XFS open call when quota has
| been exceeded in the linux-mips 2.6.14 kernel. I think that the XFS
| code has changed enough that this bug isn't in newer versions, though I
| haven't done a thorough investigation.
... I couldn't think of anything we'd changed in XFS that would have
addressed this since that kernel version.
> If there won't be any strange side effects (I don't have the experience
> to accurately comment on this), I think turning the threshold value up
> to something we can get away with in IS_ERR_VALUE() would be
> appropriate.
Seems right to me too, FWIW.
cheers.
--
Nathan
next prev parent reply other threads:[~2006-06-28 23:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-28 20:57 Erik Frederiksen
2006-06-28 21:08 ` Randy.Dunlap
2006-06-28 22:39 ` H. Peter Anvin
2006-06-29 18:10 ` Ralf Baechle
2006-07-01 18:44 ` Randy.Dunlap
2006-07-01 22:23 ` H. Peter Anvin
2006-07-02 16:15 ` Ralf Baechle
2006-07-02 17:40 ` H. Peter Anvin
2006-07-02 18:22 ` Randy.Dunlap
2006-07-02 18:27 ` [PATCH] consistently use MAX_ERRNO in __syscall_return Randy.Dunlap
2006-07-03 7:39 ` Andrew Morton
2006-07-03 15:03 ` H. Peter Anvin
2006-07-03 15:42 ` Randy.Dunlap
2006-07-03 16:09 ` H. Peter Anvin
2006-10-16 19:31 ` IS_ERR Threshold Value Andreas Mohr
2006-10-18 12:47 ` Jan Engelhardt
2006-06-28 22:41 ` Nathan Scott
2006-06-28 23:13 ` Erik Frederiksen
2006-06-28 23:22 ` Randy.Dunlap
2006-06-28 23:23 ` Nathan Scott [this message]
[not found] <6sPiW-295-5@gated-at.bofh.it>
[not found] ` <6sPsw-2y4-19@gated-at.bofh.it>
[not found] ` <6t9hu-6l6-11@gated-at.bofh.it>
[not found] ` <76GtI-T6-21@gated-at.bofh.it>
[not found] ` <77jbT-1y3-29@gated-at.bofh.it>
2006-10-18 23:29 ` Bodo Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060629092305.D1344246@wobbly.melbourne.sgi.com \
--to=nathans@sgi.com \
--cc=erik_frederiksen@pmc-sierra.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®