Re: IS_ERR Threshold Value

["Randy.Dunlap" <rdunlap@xenotime.net>]

On Sun, 2 Jul 2006 17:15:20 +0100 Ralf Baechle wrote:

> So MAX_ERRNO of EMAXERRNO which was also being used in assembler code.
> Other architectures may have the same issue, so I propose wrapping the
> C parts with #ifndef __ASSEMBLY__ to keep as happy.

Ack, fixes 'as' whinging for me.


> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
> 
> diff --git a/include/linux/err.h b/include/linux/err.h
> index cd3b367..1ab1d44 100644
> --- a/include/linux/err.h
> +++ b/include/linux/err.h
> @@ -15,6 +15,8 @@ #include <asm/errno.h>
>   */
>  #define MAX_ERRNO	4095
>  
> +#ifndef __ASSEMBLY__
> +
>  #define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO)
>  
>  static inline void *ERR_PTR(long error)
> @@ -32,4 +34,6 @@ static inline long IS_ERR(const void *pt
>  	return IS_ERR_VALUE((unsigned long)ptr);
>  }
>  
> +#endif
> +
>  #endif /* _LINUX_ERR_H */
> -


---
~Randy