mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: erik quanstrom <quanstro@quanstro.net>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>,
	Latchesar Ionkov <lionkov@gmail.com>
Cc: Eric Sesterhenn <snakebyte@gmx.de>, Russ Cox <rsc@swtch.com>,
	linux-kernel@vger.kernel.org,
	v9fs-developer@lists.sourceforge.net
Subject: Re: [V9fs-developer] [Patch] Dead code in fs/9p/vfs_inode.c
Date: Fri, 30 Jun 2006 09:12:20 -0500 (CDT)	[thread overview]
Message-ID: <20060630141220.BDD1B1B4F87@medicine-bow.quanstro.net> (raw)
In-Reply-To: <Pine.LNX.4.61.0606301544001.2313@yvahk01.tjqt.qr>

saving ten bytes once is not a good reason to do much of anything
in an era of multi-megabyte embedded devices.

i think the argument against code written in speculation is that
it confuses what the code does right now, may never be used and
if used, may be used in a situation that masks a real error.

- erik

Jan Engelhardt <jengelh@linux01.gwdg.de> writes

| 
| 
| > The comment is longer than the 10 bytes we save :)
| 
| But comments are not compiled into the final binary,
| which is what I wanted to point out. So you always
| save your 10 bytes in the object file.
| 
| 
| Jan Engelhardt

      reply	other threads:[~2006-06-30 14:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-28 22:52 Eric Sesterhenn
2006-06-28 22:55 ` [V9fs-developer] " Russ Cox
2006-06-28 23:16   ` Eric Sesterhenn / Snakebyte
2006-06-28 23:24     ` Russ Cox
2006-06-28 23:41       ` Eric Sesterhenn / Snakebyte
2006-06-29  3:58     ` David Leimbach
2006-06-29  5:27   ` Pekka Enberg
2006-06-29 11:01   ` Jan Engelhardt
2006-06-29 15:16     ` Latchesar Ionkov
2006-06-30 13:44       ` Jan Engelhardt
2006-06-30 14:12         ` erik quanstrom [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060630141220.BDD1B1B4F87@medicine-bow.quanstro.net \
    --to=quanstro@quanstro.net \
    --cc=jengelh@linux01.gwdg.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lionkov@gmail.com \
    --cc=rsc@swtch.com \
    --cc=snakebyte@gmx.de \
    --cc=v9fs-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®