From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Russ Cox" <rsc@swtch.com>
Cc: "Eric Sesterhenn" <snakebyte@gmx.de>,
linux-kernel@vger.kernel.org,
v9fs-developer@lists.sourceforge.net
Subject: Re: [V9fs-developer] [Patch] Dead code in fs/9p/vfs_inode.c
Date: Thu, 29 Jun 2006 08:27:01 +0300 [thread overview]
Message-ID: <84144f020606282227x662bdd48read6218cf2bab8fc@mail.gmail.com> (raw)
In-Reply-To: <ee9e417a0606281555k3d954236y82b11336098762be@mail.gmail.com>
On 6/29/06, Russ Cox <rsc@swtch.com> wrote:
> > error:
> > kfree(fcall);
> > - if (ret)
> > - iput(ret);
> > -
> > return ERR_PTR(err);
> > }
>
> What about when someone changes the code and does have ret != NULL here?
> This seems like reasonable defensive programming to me.
Well, you're not supposed to change code without auditing for things
like this anyway. Also, I fail to see why/how you would change
v9fs_inode_from_fid() for that to happen? I'd say kill the check.
Pekka
next prev parent reply other threads:[~2006-06-29 5:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-28 22:52 Eric Sesterhenn
2006-06-28 22:55 ` [V9fs-developer] " Russ Cox
2006-06-28 23:16 ` Eric Sesterhenn / Snakebyte
2006-06-28 23:24 ` Russ Cox
2006-06-28 23:41 ` Eric Sesterhenn / Snakebyte
2006-06-29 3:58 ` David Leimbach
2006-06-29 5:27 ` Pekka Enberg [this message]
2006-06-29 11:01 ` Jan Engelhardt
2006-06-29 15:16 ` Latchesar Ionkov
2006-06-30 13:44 ` Jan Engelhardt
2006-06-30 14:12 ` erik quanstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020606282227x662bdd48read6218cf2bab8fc@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=rsc@swtch.com \
--cc=snakebyte@gmx.de \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®